Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14325

deepDiff datasets not supported by HSC

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None

      Description

      Trying to run imageDifference.py on an HSC dataset crashes with an error saying that the deepDiff_diaSrc dataset type does not have a template. Manual inspection of obs_subaru/policy/HscMapper.yaml confirms that there are no diaSrc or deepDiff datasets mentioned.

      Please add the appropriate datasets so that we can do image differencing on HSC data.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            What is the template used for the difference images? If it's a coadd, then tract needs to be in the template for the difference image.

            At the very least, it can be either a coadd or a calexp. There may be other modes as well.

            Show
            krzys Krzysztof Findeisen added a comment - - edited What is the template used for the difference images? If it's a coadd, then tract needs to be in the template for the difference image. At the very least, it can be either a coadd or a calexp. There may be other modes as well.
            Hide
            price Paul Price added a comment -

            Then that would need to have multiple datasets, because those have different requirements on the filename template.

            Show
            price Paul Price added a comment - Then that would need to have multiple datasets, because those have different requirements on the filename template.
            Hide
            krzys Krzysztof Findeisen added a comment -

            I am not aware of any requirements (or lack thereof) on the output of ImageDifferenceTask, but reworking it seems a bit out of scope for this ticket. What do you suggest for the time being?

            Show
            krzys Krzysztof Findeisen added a comment - I am not aware of any requirements (or lack thereof) on the output of ImageDifferenceTask , but reworking it seems a bit out of scope for this ticket. What do you suggest for the time being?
            Hide
            price Paul Price added a comment -

            Well, I guess we just follow the example of obs_decam and proceed with the broken option of not including the tract, and hope this gets fixed.

            Show
            price Paul Price added a comment - Well, I guess we just follow the example of obs_decam and proceed with the broken option of not including the tract , and hope this gets fixed.
            Hide
            krzys Krzysztof Findeisen added a comment -

            I've added or updated the leading elements as requested, but not changed the name of the top-level directory. (I still don't know what a deepCoadd_*diffsrc is, but it seems to be HSC-specific and therefore not related to a generic task like ImageDifferenceTask.)

            Thanks for the review!

            Show
            krzys Krzysztof Findeisen added a comment - I've added or updated the leading elements as requested, but not changed the name of the top-level directory. (I still don't know what a deepCoadd_*diffsrc is, but it seems to be HSC-specific and therefore not related to a generic task like ImageDifferenceTask .) Thanks for the review!

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Paul Price
                Watchers:
                Eric Bellm, Krzysztof Findeisen, Meredith Rawls, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel