Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14342

validateDrp.py is broken

    XMLWordPrintable

    Details

      Description

      Using w_2018_18 and running

      validateDrp.py /datasets/hsc/repo/rerun/RC/w_2018_18/DM-14243/validateDrp/matchedVisitMetrics/9615/HSC-G/matchedVisit_HSC-G.json --noplot

      gave the following error: 

      Traceback (most recent call last):
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/validate_drp/15.0-7-gea15604/bin/validateDrp.py", line 101, in <module>
      		 
          validate.run(args.repo, **kwargs)
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/validate_drp/15.0-7-gea15604/python/lsst/validate/drp/validate.py", line 147, in run
      		 
          job = load_json_output(json_path, **kwargs)
      		 
      TypeError: load_json_output() got an unexpected keyword argument 'verbose'

      The w_2018_17 version of the same command finished okay:
      validateDrp.py /datasets/hsc/repo/rerun/RC/w_2018_17/DM-14055/validateDrp/matchedVisitMetrics/9615/HSC-G/matchedVisit_HSC-G.json --noplot

      The json file was created by running 

       matchedVisitMetrics.py /datasets/hsc/repo/rerun/RC/w_2018_18/DM-14243/ --output  /datasets/hsc/repo/rerun/RC/w_2018_18/DM-14243/validateDrp/matchedVisitMetrics/9615/HSC-G --config useJointCal=True instrumentName='HSC' datasetName='HSC-RC2' --id tract=9615 visit=26024^26028^26032^26036^26044^26046^26048^26050^26058^26060^26062^26070^26072^26074^26080^26084^26094 ccd=0..8^10..103

      The log of doing the above can be found at /datasets/hsc/repo/rerun/RC/w_2018_18/DM-14243/validateDrp/logs/matchedVisitMetrics-9615-HSC-G-139010.log

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14341 Run validate_drp with w_2018_18 HSC RC2 outputs

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            The call signature has been fixed and a test added.

            Show
            krughoff Simon Krughoff added a comment - The call signature has been fixed and a test added.
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Thanks for the quick fix. With the ticket branch I am able to run the same command without errors. 

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thanks for the quick fix. With the ticket branch I am able to run the same command without errors. 
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I actually found more breakage from this fix. I'm going to fix it on this branch.

            Show
            krughoff Simon Krughoff added a comment - I actually found more breakage from this fix. I'm going to fix it on this branch.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Green jenkins build: here.

            Merged.

            Show
            krughoff Simon Krughoff added a comment - Green jenkins build: here . Merged.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.