Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14363

Make afw::cameraGeom::Detector table-persistable

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      8
    • Epic Link:
    • Sprint:
      BG3_S18_05, BG3_F18_06, BG3_F18_07, BG3_F18_08, BG3_F18_09, BG3_F18_10
    • Team:
      Data Release Production

      Description

      In Gen3, we're planning to just persist Detectors with Exposures to make each Exposure more self-contained and avoid complex modify-on-load code (which would have had to get more complex than what we have now to handle camera versioning).  This means we need a way to save a Detector inside an Exposure, and at least at present, that means making it inherit from afw::table::io::Persistable.

       

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15528 Make cameraGeom::Camera round-trip persistable

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15918 Make Camera round-trip persistable via afw::table::io

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Yusra AlSayyad, mind taking this review?  I know you're frequently overloaded by reviews, so feel free to redirect some of those towards me as penance.

            Also not urgent: this is sitting on top tickets/DM-14980, which also has not been reviewed yet.

            Show
            jbosch Jim Bosch added a comment - Yusra AlSayyad , mind taking this review?  I know you're frequently overloaded by reviews, so feel free to redirect some of those towards me as penance. Also not urgent: this is sitting on top tickets/ DM-14980 , which also has not been reviewed yet.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment - - edited

            Will you open a PR? I can only comment on either a PR or a commit and there are a lot of commits.

            Oh whoops. You did. I didn't see it before.

            Show
            yusra Yusra AlSayyad added a comment - - edited Will you open a PR? I can only comment on either a PR or a commit and there are a lot of commits. Oh whoops. You did. I didn't see it before.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Yup, sorry, just forgot that Jira probably wouldn't spot it: https://github.com/lsst/afw/pull/401

             

            Show
            jbosch Jim Bosch added a comment - Yup, sorry, just forgot that Jira probably wouldn't spot it: https://github.com/lsst/afw/pull/401  
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            I didn't see any issues with it. Anything you want me to do to test?

            I made some comments on github. Mostly thoughts while reading rather than things to change.
            And style-wise I think I misunderstood what happed during https://jira.lsstcorp.org/browse/RFC-261 I didn't comment on style except for a few spots that were really different.

            Show
            yusra Yusra AlSayyad added a comment - I didn't see any issues with it. Anything you want me to do to test? I made some comments on github. Mostly thoughts while reading rather than things to change. And style-wise I think I misunderstood what happed during https://jira.lsstcorp.org/browse/RFC-261 I didn't comment on style except for a few spots that were really different.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Thanks!  I don't think there's anything for you to test; Tim Jenness was able to consistently reproduce the bug that was present before, so I think that pretty strongly confirmed that it was fixed.

            And r.e. style, I'm glad you did comment where you did - I may be having a hard time not telling people to get off my hand-formatted lawn these days, but knowing where I differ from clang-format in a way that is jarring to readers is an important thing for me to know and try to adapt to.

            Show
            jbosch Jim Bosch added a comment - Thanks!  I don't think there's anything for you to test; Tim Jenness was able to consistently reproduce the bug that was present before, so I think that pretty strongly confirmed that it was fixed. And r.e. style, I'm glad you did comment where you did - I may be having a hard time not telling people to get off my hand-formatted lawn these days, but knowing where I differ from clang-format in a way that is jarring to readers is an important thing for me to know and try to adapt to.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.