Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14429

Implement RFC-460: move afw.geom content to new geom package

    Details

    • Story Points:
      6
    • Sprint:
      DRP S18-6
    • Team:
      Alert Production

      Description

      Finish implementing RFC-460; see that ticket for description.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            I also updated meas_base, meas_algorithms and meas_astrom (all of which needed small changes due to missing includes) to use geom and did some C++ cleanup (clang-format and modernizing some old namespace usage).

            Show
            rowen Russell Owen added a comment - I also updated meas_base, meas_algorithms and meas_astrom (all of which needed small changes due to missing includes) to use geom and did some C++ cleanup (clang-format and modernizing some old namespace usage).
            Hide
            jbosch Jim Bosch added a comment - - edited

            I've attached depr.cc as an example of how we could use the [[deprecated] tag on the backwards-compatibility typedefs. As discussed on the afw PR, I think adding those would be a bit problematic, but maybe we can find a creative way to get the upside of that without the downsides.

            Show
            jbosch Jim Bosch added a comment - - edited I've attached depr.cc as an example of how we could use the [ [deprecated] tag on the backwards-compatibility typedefs. As discussed on the afw PR, I think adding those would be a bit problematic, but maybe we can find a creative way to get the upside of that without the downsides.
            Hide
            jbosch Jim Bosch added a comment -

            Review complete.  There are a few minor comments on the PRs, with the only big open question being Krzysztof Findeisen's deprecation idea.  As noted on the PRs, I did not look carefully at obvious find-replace commits; please let me know if I should in any particular cases.

            Show
            jbosch Jim Bosch added a comment - Review complete.  There are a few minor comments on the PRs, with the only big open question being Krzysztof Findeisen 's deprecation idea.  As noted on the PRs, I did not look carefully at obvious find-replace commits; please let me know if I should in any particular cases.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the helpful review. geom updated as per request.

            Show
            rowen Russell Owen added a comment - Thank you for the helpful review. geom updated as per request.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel