Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1448

Move code for mock images into afw so it reusable.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, ip_isr
    • Labels:
      None

      Description

      There is some code in the exampleUtils in $IP_ISR_DIR/examples that could be of wider use. Specifically there is code to generate mock darks, flats, and raw data from a mock camera. There is also code to generate a mock dataRef. It could be used more widely if moved someplace else. Russell suggested afw.cameraGeom.utils.

        Attachments

          Issue Links

          is FF-depended by

          Improvement - An improvement or enhancement to an existing feature or task. DM-18345 isrMock assumes gain=1.0

          • To Do

          Improvement - An improvement or enhancement to an existing feature or task. DM-15683 Add tests for ip_isr/isrTask

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9197 runIsrTask.py example (also) not working on current stack

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Look into whether the examples are useful.

            Show
            yusra Yusra AlSayyad added a comment - Look into whether the examples are useful.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            The ip_isr/examples directory did not contain anything useful, with a number of methods in the exampleUtils.py file no longer matching current APIs.  In addition, the isr.py and runAssembleTask.py scripts duplicate behavior that can be obtained from teh standard runIsr.py command line script.

            I have copied some of the useful code from exampleUtils.py into a new isrMock class, that allows mock exposures to be generated based on the utilities and definitions in afw/cameraGeom.  This should update the concepts from exampleUtils.py into something easier to use for unit tests (such as for DM-15683).

            Show
            czw Christopher Waters added a comment - The ip_isr/examples directory did not contain anything useful, with a number of methods in the exampleUtils.py file no longer matching current APIs.  In addition, the isr.py and runAssembleTask.py scripts duplicate behavior that can be obtained from teh standard runIsr.py command line script. I have copied some of the useful code from exampleUtils.py into a new isrMock class, that allows mock exposures to be generated based on the utilities and definitions in afw/cameraGeom.  This should update the concepts from exampleUtils.py into something easier to use for unit tests (such as for DM-15683 ).
            Hide
            Permalink
            czw Christopher Waters added a comment -

            One additional point: I did not move the code to afw, as afw/cameraGeom already has useful mock generation code (the basis for the isrMock).  As the new code is fairly ISR specific, I kept it as part of ip_isr.

            Show
            czw Christopher Waters added a comment - One additional point: I did not move the code to afw, as afw/cameraGeom already has useful mock generation code (the basis for the isrMock).  As the new code is fairly ISR specific, I kept it as part of ip_isr.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            FWIW, this sounds great to me.

            Show
            krughoff Simon Krughoff added a comment - FWIW, this sounds great to me.

              People

              Assignee:
              czw Christopher Waters
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Merlin Fisher-Levine
              Watchers:
              Christopher Waters, Merlin Fisher-Levine, Russell Owen, Simon Krughoff, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.