Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Firefly
-
Labels:
-
Story Points:5
-
Epic Link:
-
Sprint:SUIT Sprint 2018-09
-
Team:Science User Interface
Description
Inside Firefly, there is a UI option to place "footprints" (e.g., of astronomical instruments) over displayed images. Footprints are created from region files in the Firefly repo (https://github.com/Caltech-IPAC/firefly/tree/dev/src/firefly_data/footprint) and appear to be treated by Firefly as standard DS9 region files where the ra,dec coordinate system is treated as having a relocatable origin and orientation (i.e., as field angles rather than true ra and dec).
It would be very nice to make this capability available (1) in the UI, for region data uploaded from a file by a user, and (2) in the API, for region data sent from the JavaScript and/or Python APIs.
For (1), one possibility would be that the region file upload dialog might get a check-box added to it saying "make origin movable" or "treat as footprint". Alternatively, an "upload footprint" element might get added to the existing footprint menu.
Please see also tickets I've filed in the IRSA system, including IRSA-1612 and IRSA-1613, regarding the treatment of footprints and their coordinates in the layer dialog.
Attachments
Issue Links
- relates to
-
DM-14515 Improvements to Firefly footprint menu
- Done
- links to
Activity
In the API (but not in the UI) I would also suggest adding the capability to dynamically add an uploaded relocatable footprint to the marker/footprint menu. (But this could be deferred to a subsequent follow-on ticket.)
Some thought about this 'upload footprint' feature. Two kinds of footprint 'origin' are treated currently by Firefly, one is the physical origin, i.e. (0,0) on either world coordinate or image coordinate, the other one is the center of the footprint, distance center based on the region shape. So how about two checkboxes to be provided for relocating (0,0) or the center of the footprint?
conclusion from LSST group discussion: only (0,0) is considered as the origin for relocation at the point
Discussed at Firefly CCB today.
Consensus: in the APIs, provide a means to declare, at the time of uploading a region file, whether the region(s) in the file will be treated as relocatable or not.
In the UI, we suggest that a single "upload region" action still be used, but that in the resulting dialog a checkbox be provided that controls whether or not the region(s) in the file are treated as relocatable.
We have not discussed whether an already uploaded and displayed region could be made relocatable. Gregory Dubois-Felsmann's personal opinion is: let's not do this (at least not without user feedback requesting it).