Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14527

Implement RFC-483: fix image bbox slicing origin

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP S18-6, DRP F18-1, DRP F18-2
    • Team:
      Data Release Production

      Description

      Add operator[](Box2I), operator[](Point2I), operator[](int, int) to C++ image interfaces, taking into account xy0. Wrap for Python using a temporary alternate method name.

      Remove old Python implementation of __getitem__ and __call__.

      Update any code that used the old APIs to use the new temporary ones.

      Switch from temporary names to __getitem__ and update downstream code accordingly (via regex or similar).

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-483 Account for xy0 by default in image[box] slicing

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-486 Remove single-pixel get/set from afw::image Python wrappers

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15078 Edit "Image Indexing, Array Views, and Bounding Boxes" documentation topic in lsst.afw.image

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            While it would be easier (for me) to push the DM-13911 first, I think it would probably be better to get this ticket merged first so that I can update DM-13911 appropriately. If I merge first then this ticket won't break anything, but we could potentially miss cleaning up `MultbandBase` to take advantage of the new `Image` behavior.

            Show
            fred3m Fred Moolekamp added a comment - While it would be easier (for me) to push the DM-13911 first, I think it would probably be better to get this ticket merged first so that I can update DM-13911 appropriately. If I merge first then this ticket won't break anything, but we could potentially miss cleaning up `MultbandBase` to take advantage of the new `Image` behavior.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            I left a few comments in afw and meas_algorithms. All of the other packages look fine.

            Show
            fred3m Fred Moolekamp added a comment - I left a few comments in afw and meas_algorithms. All of the other packages look fine.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            All comments addressed or debated.  Please take another look when you get a chance.

             

            Show
            jbosch Jim Bosch added a comment - All comments addressed or debated.  Please take another look when you get a chance.  
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Ok, everything looks good except that I'd like you to reconsider another method that allows for using negative indices when origin = PARENT. Please see the comment in the PR.

            Show
            fred3m Fred Moolekamp added a comment - Ok, everything looks good except that I'd like you to reconsider another method that allows for using negative indices when origin = PARENT . Please see the comment in the PR.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Merged to master.  Thanks for the quick and helpful review, Fred Moolekamp.

            Show
            jbosch Jim Bosch added a comment - Merged to master.  Thanks for the quick and helpful review, Fred Moolekamp .

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.