Status: Won't Fix
Fix Version/s: None
Sprint:DRP F19-5, DRP F19-6 (Nov), DRP S20-2 (Jan), DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May), DRP F20-1 (June), DRP F20-2 (July), DRP F20-3 (Aug), DRP F20-5 (Oct), DRP S21a (Dec Jan)
Team:Data Release Production
The pipe_analysis repository provides scripts which inspect a repository of processed data and generate static plots of the distributions of scientifically relevant quantities. These may be manually inspected to demonstrate the internal consistency and fidelity of photometric and astrometric measurements on the visit-stage and coadd-stage catalog outputs. They also can be used to compare catalog outputs from two different reruns.
The pipe_analysis repository currently resides in the lsst-dm GitHub organization and has historically been developed largely from the point of view of performing QA on HSC-SSP processing to reveal and diagnose any issues arising in the LSST codebase. As such, it has not been developed and code-reviewed under the same strict guidelines to which the main lsst repository code development must comply.
More recently, the products of this repository have proven (and been deemed) more generally useful (e.g. they are now currently run and inspected as part of the bi-weekly HSC RC2 dataset reprocessing, see https://confluence.lsstcorp.org/display/DM/Reprocessing+of+the+HSC+RC2+dataset), so there is a desire to have it moved into the main lsst repository (and, to begin, have the main functionality CI'd by running the scripts as part of ci_hsc, noting that a human eye inspecting the individual plots would still be required to check their fidelity). Before this can happen, however, the code must be brought into compliance with the lsst coding standards (as outlined in the LSST DM Developer Guide: https://developer.lsst.io/index.html).
This ticket is meant as a bucket to list all the required/desired changes to be made (input from others is strongly encouraged/desired!). Individual tickets will be created for the individual changes (to the extent to which they can be atomized). When we believe compliance has been achieved, an RFC to make the move from the lsst-dm to the lsst GitHub organization will be created.
- relates to
DM-26607 Make pipe_analysis flake8 compliant and enable Travis and branch protections