Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14580

Create tests for BestSeeingWcsSelectImagesTask.

    Details

      Description

      Due to travel it was preferable to review DM-11953 without a unit test. This ticket is to create the missing tests, possibly with advice from Russell Owen.

        Attachments

          Issue Links

            Activity

            Hide
            ebellm Eric Bellm added a comment -

            Hi Meredith Rawls, here's the review of the image selector tests...

            Show
            ebellm Eric Bellm added a comment - Hi Meredith Rawls , here's the review of the image selector tests...
            Hide
            mrawls Meredith Rawls added a comment -

            Thanks for writing some tests! I added a suggestion for testing a more realistic situation over on GitHub, which I don't think will take very long to implement.

            Show
            mrawls Meredith Rawls added a comment - Thanks for writing some tests! I added a suggestion for testing a more realistic situation over on GitHub, which I don't think will take very long to implement.
            Hide
            ebellm Eric Bellm added a comment -

            Hi Meredith Rawls, I've made the suggested changes--can you take another look?

            Show
            ebellm Eric Bellm added a comment - Hi Meredith Rawls , I've made the suggested changes--can you take another look?
            Hide
            mrawls Meredith Rawls added a comment -

            Thanks for adding a test to confirm it actually selects the best seeing images!

            This looks great. I'll note here for posterity that there is a fundamental issue with the BestSeeingWcsSelectImagesTask that is discussed in DM-16191. Once a resolution to that is complete, I'd love to see the tests expanded to ensure the images it selects cover some large fraction of the available sky area.

            Show
            mrawls Meredith Rawls added a comment - Thanks for adding a test to confirm it actually selects the best seeing images! This looks great. I'll note here for posterity that there is a fundamental issue with the BestSeeingWcsSelectImagesTask that is discussed in DM-16191 . Once a resolution to that is complete, I'd love to see the tests expanded to ensure the images it selects cover some large fraction of the available sky area.

              People

              • Assignee:
                ebellm Eric Bellm
                Reporter:
                ebellm Eric Bellm
                Reviewers:
                Meredith Rawls
                Watchers:
                Eric Bellm, Meredith Rawls
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: