Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14580

Create tests for BestSeeingWcsSelectImagesTask.

    XMLWordPrintable

    Details

      Description

      Due to travel it was preferable to review DM-11953 without a unit test. This ticket is to create the missing tests, possibly with advice from Russell Owen.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11953 Improve MaxPsfWcsSelectImagesTask

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            ebellm Eric Bellm created issue -
            ebellm Eric Bellm made changes -
            Field Original Value New Value
            Epic Link DM-12711 [ 36308 ]
            ebellm Eric Bellm made changes -
            Link This issue is blocked by DM-11953 [ DM-11953 ]
            ebellm Eric Bellm made changes -
            Risk Score 0
            ebellm Eric Bellm made changes -
            Epic Link DM-12711 [ 36308 ] DM-14431 [ 80156 ]
            ebellm Eric Bellm made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Hi Meredith Rawls, here's the review of the image selector tests...

            Show
            ebellm Eric Bellm added a comment - Hi Meredith Rawls , here's the review of the image selector tests...
            ebellm Eric Bellm made changes -
            Reviewers Meredith Rawls [ mrawls ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Thanks for writing some tests! I added a suggestion for testing a more realistic situation over on GitHub, which I don't think will take very long to implement.

            Show
            mrawls Meredith Rawls added a comment - Thanks for writing some tests! I added a suggestion for testing a more realistic situation over on GitHub, which I don't think will take very long to implement.
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Hi Meredith Rawls, I've made the suggested changes--can you take another look?

            Show
            ebellm Eric Bellm added a comment - Hi Meredith Rawls , I've made the suggested changes--can you take another look?
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Thanks for adding a test to confirm it actually selects the best seeing images!

            This looks great. I'll note here for posterity that there is a fundamental issue with the BestSeeingWcsSelectImagesTask that is discussed in DM-16191. Once a resolution to that is complete, I'd love to see the tests expanded to ensure the images it selects cover some large fraction of the available sky area.

            Show
            mrawls Meredith Rawls added a comment - Thanks for adding a test to confirm it actually selects the best seeing images! This looks great. I'll note here for posterity that there is a fundamental issue with the BestSeeingWcsSelectImagesTask that is discussed in DM-16191 . Once a resolution to that is complete, I'd love to see the tests expanded to ensure the images it selects cover some large fraction of the available sky area.
            mrawls Meredith Rawls made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ebellm Eric Bellm made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              ebellm Eric Bellm
              Reporter:
              ebellm Eric Bellm
              Reviewers:
              Meredith Rawls
              Watchers:
              Eric Bellm, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.