Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14591

Fix handling of filter in templates

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      1
    • Sprint:
      BG3_S18_05, BG3_F18_06, BG3_F18_07, BG3_F18_08, BG3_F18_09, BG3_F18_10, BG3_F18_11, BG3_S19_01, BG3_S19_02
    • Team:
      Data Release Production

      Description

      Commit 2d46b0cd620cc07b45baa191dcc280e9130dfeb9 makes filter optional in the test Butler template for calexp. This is needed because fitler isn't handled properly.
      Filter is a special case because both abstract_filter and physical_filter exist but filter does not.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Those templates have moved around since Pim Schellart [X] last worked on this, but the problem remains.  All templates in daf_butler need to use either physical_filter or abstract_filter instead of just filter.

            Show
            jbosch Jim Bosch added a comment - Those templates have moved around since Pim Schellart [X] last worked on this, but the problem remains.  All templates in daf_butler need to use either physical_filter or abstract_filter instead of just filter.
            Hide
            jbosch Jim Bosch added a comment -

            Fixing this properly is more difficult than it seems: including physical_filter in places where it should be usable requires being able to expand Data IDs that just have Visit or Exposure to include PhysicalFilter as well.

            Show
            jbosch Jim Bosch added a comment - Fixing this properly is more difficult than it seems: including physical_filter in places where it should be usable requires being able to expand Data IDs that just have Visit or Exposure to include PhysicalFilter as well.
            Hide
            jbosch Jim Bosch added a comment -

            This was actually resolved (not just unblocked) by DM-15675.

            Show
            jbosch Jim Bosch added a comment - This was actually resolved (not just unblocked) by DM-15675 .

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Watchers:
                Jim Bosch, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: