Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14625

Fix ndarray compiler warnings

    XMLWordPrintable

    Details

      Description

      Fix ndarray compiler warnings in the few remaining packages that have not been updated.

      This consists of removing

          if (_import_array() < 0) {
              PyErr_SetString(PyExc_ImportError, "numpy.core.multiarray failed to import");
              return nullptr;
          }
      

      and import of numpy headers from pybind11 wrappers

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I also took the opportunity to tweak flake8 testing as follows:

            • enable automatic flake8 testing for meas_extensions_simpleShape (which had very few flake8 errors, so this was trivial)
            • finish enabling scons flake8 testing in meas_modelfit; the config files were there but tests/SConstruct had not been updated
            • finish enabling flake8 testing in shapelet; setup.cfg was there, but scons was not running flake8 and the Travis file was missing and there were a few flake8 errors
            Show
            rowen Russell Owen added a comment - - edited I also took the opportunity to tweak flake8 testing as follows: enable automatic flake8 testing for meas_extensions_simpleShape (which had very few flake8 errors, so this was trivial) finish enabling scons flake8 testing in meas_modelfit ; the config files were there but tests/SConstruct had not been updated finish enabling flake8 testing in shapelet ; setup.cfg was there, but scons was not running flake8 and the Travis file was missing and there were a few flake8 errors
            Hide
            nlust Nate Lust added a comment -

            I see no problems beside a question I brought up on slack, but that would be a ticket in its own (pending how the discussion goes) so I see no reason to hold this up.

            Show
            nlust Nate Lust added a comment - I see no problems beside a question I brought up on slack, but that would be a ticket in its own (pending how the discussion goes) so I see no reason to hold this up.
            Hide
            nlust Nate Lust added a comment -

            The only question I really did have is that you enabled flake8 testing with scons. Was this ever part of an rfc? Not that I personally have a problem with doing this, but some people might have their own workflows and might not want want to be interrupted with this. It may be that the rfc just passed me by, as I dont always catch everything going on.

            Show
            nlust Nate Lust added a comment - The only question I really did have is that you enabled flake8 testing with scons. Was this ever part of an rfc? Not that I personally have a problem with doing this, but some people might have their own workflows and might not want want to be interrupted with this. It may be that the rfc just passed me by, as I dont always catch everything going on.
            Hide
            rowen Russell Owen added a comment -

            It's a standard part of our workflow. We've been adapting packages as we come to them.

            in this case the flake8 config file was already present and it was likely an oversight that pyList=[] had not been added to tests/SConscript

            Show
            rowen Russell Owen added a comment - It's a standard part of our workflow. We've been adapting packages as we come to them. in this case the flake8 config file was already present and it was likely an oversight that pyList=[] had not been added to tests/SConscript
            Show
            tjenness Tim Jenness added a comment - In particular: https://developer.lsst.io/stack/adding-a-new-package.html?highlight=flake8#configuring-github-repositories

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Nate Lust
              Watchers:
              Nate Lust, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.