Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14658

Fix Gen3 SkyMap registration after polygon API changes

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      BG3_S18_05
    • Team:
      Data Release Production

      Description

      BaseSkyMap now has a register method that adds that SkyMap to a Gen3 Butler repository (even on master - while this was originally an oversight, it does no harm there).  That code was broken by changes on master to other SkyMap APIs, so we need to fix this to sync the gen3-middleware branch up with master.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jbosch Jim Bosch added a comment -

          Russell Owen, could you take a look at this?  The changes are trivial; I mostly wanted to make sure you don't disagree strongly with my rational for fixing this code on master rather than removing it (and instead maintaining a gen3-middleware branch).

           

          Show
          jbosch Jim Bosch added a comment - Russell Owen , could you take a look at this?  The changes are trivial; I mostly wanted to make sure you don't disagree strongly with my rational for fixing this code on master rather than removing it (and instead maintaining a gen3-middleware branch).  
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Looks good and I agree that master is a fine place for it

          Show
          rowen Russell Owen added a comment - Looks good and I agree that master is a fine place for it
          Hide
          Permalink
          jbosch Jim Bosch added a comment -

          Thanks for the quick review!

          Show
          jbosch Jim Bosch added a comment - Thanks for the quick review!

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Russell Owen
            Watchers:
            Jim Bosch, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.