Details
-
Type:
Technical task
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:
-
Sprint:Science Pipelines DM-W15-2
-
Team:Data Release Production
Description
Remove the old classes that were used to wrap algorithms using the old C++ interface. This includes (at least):
- The Input classes
- The Component classes and Result templates in Results.h
- The ComponentMapper classes and ResultMapper templates in ResultMappers.h
- The old WrappedSingleFrameAlgorithm and WrappedForcedPlugin classes.
We should double-check that meas_multifit still builds after this change; I'm pretty certain the CModel algorithm wrappers don't use any of the old stuff, but I'm not completely positive.
Attachments
Activity
Only comments are a few more things that should be removed:
- Inputs.h, Results.h, and ResultMappers.h - we can just delete these files entirely (and I think you must have intended to, as the corresponding .cc files were deleted)
- the lines that refer to FlagDef in baseLib.i; FlagDef was part of the old FlagsComponent
- the WrappedSingleFramePlugin class in sfm.py should be removed (the one in wrappers.py should stay)
- the WrappedForcedPlugin class in forcedMeasurement.py should be removeed (the one in wrapppers.py should stay)
One more complication: there is code in meas_modelfit that includes Results.h, and will hence fail if we remove it. However, it looks like we should be able to replace that with an include of meas/base/constants.h, which we're not removing. I'm testing whether that works now. We should not merge meas_base until we have a fix for meas_modelfit as well.
I confirmed the fix for meas_modelfit, and then went ahead and merged it to master, since the change was backwards-compatible. So there's no need to worry about that anymore; just merge meas_base when it's ready.
Sorry this checkin was sloppy. I did it quickly from memory when my branch merge got mixed up, and I obviously didn't remember everything.
Perry Gee
added a comment - Sorry this checkin was sloppy. I did it quickly from memory when my branch merge got mixed up, and I obviously didn't remember everything. 
This is the last of the
DM-1130changes.I only removed the instantiate methods and references to Results, ResultMappers, and Inputs, as well as their h and cc files.
I wasn't sure if the remainder of baseLib.i was useful or not.