Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: display_firefly, Firefly
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2018-06
-
Team:Science User Interface
Description
When using the Firefly backend for lsst.afw.display, the first MaskedImage or Exposure displayed via Display.mtv has a wonderful mask overlay (much better than DS9's!).
Unfortunately, if I call mtv a second time on the same Display instance, the mask overlays do not appear, even though the image itself is updated.
If I close the image window in Firefly itself before calling Display.mtv, things work as expected.
If a quick fix is possible, it'd be great to get it in this week so I can avoid demoing the workaround at LSST@Europe3 next week (but it's not a terrible workaround if quick fix is not possible).
Attachments
Issue Links
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Risk Score | 0 |
David Shupe
made changes -
| Assignee | David Shupe [ shupe ] |
David Shupe
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Sprint | SUIT Sprint 2018-06 [ 705 ] | |
| Watchers | David Shupe, Jim Bosch, Trey Roby [ David Shupe, Jim Bosch, Trey Roby ] | David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Trey Roby, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Trey Roby, Xiuqin Wu ] |
| Assignee | David Shupe [ shupe ] | Trey Roby [ roby ] |
| Reviewers | Cindy Wang [ cwang ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Remote Link | This issue links to "Pull Request (Web Link)" [ 17129 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Component/s | display_firefly [ 15115 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
It was decided to make a fix on the Firefly server instead of deleting the image before mtv. Unfortunately I am finding the problem is still occurring when using the https://lsp-demo.lsst.codes/firefly.
David Shupe
added a comment - It was decided to make a fix on the Firefly server instead of deleting the image before mtv . Unfortunately I am finding the problem is still occurring when using the https://lsp-demo.lsst.codes/firefly . | Epic Link |
|
We were able to reproduce the problem on my laptop. The issue was fixed in review, by this commit. Masks appear reliably now, on my laptop and on the lsp-demo platform.
David Shupe
added a comment - We were able to reproduce the problem on my laptop. The issue was fixed in review, by this commit . Masks appear reliably now, on my laptop and on the lsp-demo platform. | Story Points | 2 |
The behavior of the masks is server-dependent, in my testing. Running the intro-with-globuler notebook and using the lsp-demo.lsst.codes Firefly server, the masks don't appear after the first Display.mtv. On the last-demo.ncsa.illinois.edu server, the masks still display in my testing.
We are testing a fix on the display_firefly side, that would delete the displayed image at the start of mtv.