Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14725

Eliminate explicit use of ndarray::EigenView in C++ code

    XMLWordPrintable

    Details

      Description

      ndarray::EigenView relies on undocumented internals of Eigen. Stop using it, in order to allow upgrading Eigen.

      The full conversion consists of two parts:
      1) Stop using ndarray::EigenView explicitly in C++ code. That is what this ticket is about.
      2) Stop using ndarray::EigenView indirectly via ndarray::Array::asEigen by having that function return an Eigen::Map. That is DM-14728

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14305 Upgrade Eigen to 3.3.4

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-14728 Add asEigenArray/Matrix returning Eigen::Map

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14740 Stop using ndarray::EigenView indirectly in C++ code

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-479 Upgrade Eigen to 3.3.4

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-10068 [ 31628 ]
            rowen Russell Owen made changes -
            Link This issue relates to RFC-479 [ RFC-479 ]
            rowen Russell Owen made changes -
            Risk Score 0
            rowen Russell Owen made changes -
            Link This issue blocks DM-14305 [ DM-14305 ]
            rowen Russell Owen made changes -
            Summary Eliminate usage of ndarray::EigenView Eliminate use of ndarray::EigenView in C++ code
            rowen Russell Owen made changes -
            Description ndarray::EigenView relies on undocumented internals of Eigen. Stop using it, in order to allow upgrading Eigen. ndarray::EigenView relies on undocumented internals of Eigen. Stop using it, in order to allow upgrading Eigen.

            The full conversion consists of two parts:
            1) Stop using {{ndarray::EigenView}} explicitly in C++ code. That is what this ticket is about.
            2) Stop using {{ndarray::EigenView}} indirectly via {{ndarray::Array::asEigen}} by having that function return an {{Eigen::Map}}. I'll file a separate ticket for that. It will be tricky because we have to be sure memory is being managed properly for all the objects returned by {{asEigen}}.
            rowen Russell Owen made changes -
            Link This issue relates to DM-14728 [ DM-14728 ]
            rowen Russell Owen made changes -
            Summary Eliminate use of ndarray::EigenView in C++ code Eliminate explicit use of ndarray::EigenView in C++ code
            rowen Russell Owen made changes -
            Story Points 10 2
            rowen Russell Owen made changes -
            Story Points 2 1
            rowen Russell Owen made changes -
            Sprint AP S18-6 [ 686 ]
            rowen Russell Owen made changes -
            Description ndarray::EigenView relies on undocumented internals of Eigen. Stop using it, in order to allow upgrading Eigen.

            The full conversion consists of two parts:
            1) Stop using {{ndarray::EigenView}} explicitly in C++ code. That is what this ticket is about.
            2) Stop using {{ndarray::EigenView}} indirectly via {{ndarray::Array::asEigen}} by having that function return an {{Eigen::Map}}. I'll file a separate ticket for that. It will be tricky because we have to be sure memory is being managed properly for all the objects returned by {{asEigen}}.             		ndarray::EigenView relies on undocumented internals of Eigen. Stop using it, in order to allow upgrading Eigen.

            The full conversion consists of two parts:
            1) Stop using {{ndarray::EigenView}} explicitly in C++ code. That is what this ticket is about.
            2) Stop using {{ndarray::EigenView}} indirectly via {{ndarray::Array::asEigen}} by having that function return an {{Eigen::Map}}. That is DM-14728
            rowen Russell Owen made changes -
            Reviewers Krzysztof Findeisen [ krzys ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            krzys Krzysztof Findeisen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-14740 [ DM-14740 ]
            swinbank John Swinbank made changes -
            Epic Link DM-10068 [ 31628 ] DM-14447 [ 80385 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, John Parejko, Krzysztof Findeisen, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.