Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14728

Add asEigenArray/Matrix returning Eigen::Map

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ndarray

      Description

      Add ndarray::asEigenArray(array) and asEigenMatrix(array) which return Eigen::Map.

      Also make it possible (or automatic) to eliminate ndarray::Array::asEigen and ndarray::EigenView when building against a more modern version of Eigen.

      This is to help LSST upgrade Eigen, which will probably require eliminating our use of ndarray::EigenView.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14305 Upgrade Eigen to 3.3.4

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-14740 Stop using ndarray::EigenView indirectly in C++ code

          • Done
          mitigates

          Bug - A problem which impairs or prevents the functions of the product. DM-9677 ndarray sometimes fails to build using lsstsw

          • Done
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-479 Upgrade Eigen to 3.3.4

          • Implemented

          Improvement - An improvement or enhancement to an existing feature or task. DM-14725 Eliminate explicit use of ndarray::EigenView in C++ code

          • Done

            Activity

            Ascending order - Click to sort in descending order
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-10068 [ 31628 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-14725 [ DM-14725 ]
            rowen Russell Owen made changes -
            Risk Score 0
            rowen Russell Owen made changes -
            Link This issue relates to RFC-479 [ RFC-479 ]
            rowen Russell Owen made changes -
            Link This issue blocks DM-14305 [ DM-14305 ]
            rowen Russell Owen made changes -
            Story Points 20 10
            rowen Russell Owen made changes -
            Component/s afw [ 10714 ]
            Component/s meas_astrom [ 10745 ]
            Component/s ndarray [ 10761 ]
            rowen Russell Owen made changes -
            Summary Change ndarray asEigen to return Eigen::Map instead of ndarray::EigenView Add asEigenArray/Matrix returning Eigen::Map
            rowen Russell Owen made changes -
            Component/s afw [ 10714 ]
            Component/s meas_astrom [ 10745 ]
            rowen Russell Owen made changes -
            Description Change {{ndarray::Array::asEigen}} to return {{Eigen::Map}} instead of {{ndarray::EigenView}} and update the DM stack accordingly.

            The primary concern is that {{EigenView}} manages its memory and {{Eigen::Map}} does not so we have to be careful not to introduce memory leaks.             		Add {{ndarray::Array::asEigenArray}} and {{asEigenMatrix}} which return {{Eigen::Map}}.

            Also make it possible (or automatic) to eliminate {{ndarray::Array::asEigen}} and {{ndarray::EigenView}} when building against a more modern version of Eigen.

            This is to help LSST upgrade Eigen, which will probably require eliminating our use of {{ndarray::EigenView}}.
            rowen Russell Owen made changes -
            Assignee Russell Owen [ rowen ] Jim Bosch [ jbosch ]
            rowen Russell Owen made changes -
            Link This issue blocks DM-14740 [ DM-14740 ]
            rowen Russell Owen made changes -
            Description Add {{ndarray::Array::asEigenArray}} and {{asEigenMatrix}} which return {{Eigen::Map}}.

            Also make it possible (or automatic) to eliminate {{ndarray::Array::asEigen}} and {{ndarray::EigenView}} when building against a more modern version of Eigen.

            This is to help LSST upgrade Eigen, which will probably require eliminating our use of {{ndarray::EigenView}}.             		Add {{ndarray::asEigenArray(array)}} and {{asEigenMatrix(array)}} which return {{Eigen::Map}}.

            Also make it possible (or automatic) to eliminate {{ndarray::Array::asEigen}} and {{ndarray::EigenView}} when building against a more modern version of Eigen.

            This is to help LSST upgrade Eigen, which will probably require eliminating our use of {{ndarray::EigenView}}.
            rowen Russell Owen made changes -
            Assignee Jim Bosch [ jbosch ] Russell Owen [ rowen ]
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Epic Link DM-10068 [ 31628 ] DM-14447 [ 80385 ]
            rowen Russell Owen made changes -
            Link This issue mitigates DM-9677 [ DM-9677 ]
            rowen Russell Owen made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status In Review [ 10004 ] Done [ 10002 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.