Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: display_firefly, SUIT
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2018-06
-
Team:Science User Interface
Description
A common pattern for using afw.display is to display an image with a zoom level. With the Firefly backend, currently it is necessary to mtv (display) the image and then issue a zoom command. This displays the entire image, which can take some time for large images, and then applies the zoom. This improvement is for the backend to keep track of the last commanded zoom level, and to include it in the call to FIreflyClient.show_fits.
Attachments
Issue Links
- relates to
-
DM-15333 Apply pan and scale at time of image display in display_firefly
- Done
Activity
David Shupe
created issue -
David Shupe
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Risk Score | 0 |
David Shupe
made changes -
| Epic Link |
|
David Shupe
made changes -
| Sprint | SUIT Sprint 2018-06 [ 705 ] | |
| Story Points | 2 | |
| Team | Science User Interface [ 10303 ] | |
| Watchers | David Shupe [ David Shupe ] | David Shupe, Gregory Dubois-Felsmann, Simon Krughoff, Trey Roby, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Simon Krughoff, Trey Roby, Xiuqin Wu ] |
| Description | A common pattern for using {{afw.display}} is to display an image with a zoom level. With the Firefly backend, currently it is necessary to {{mtv}} (display) the image and then issue a zoom command. This displays the entire image, which can take some time for large images, and then applies the zoom. This improvement is for the backend to keep track of the last commanded zoom level, and to include it in the call to {{FIreflyClient.show_fits}}. |
| Component/s | display_firefly [ 15115 ] |
David Shupe
made changes -
| Reviewers | Jim Bosch [ jbosch ] | |
| Status | To Do [ 10001 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
David Shupe
made changes -
| Watchers | David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Simon Krughoff, Trey Roby, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Simon Krughoff, Trey Roby, Xiuqin Wu ] | David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Robert Lupton, Simon Krughoff, Trey Roby, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Robert Lupton, Simon Krughoff, Trey Roby, Xiuqin Wu ] |
David Shupe
added a comment - The implementation in the tickets/ DM-14734 branch introduced a typo in a parameter for Firefly, which re-introduced the region overlay problem of DM-14732 . A one-line change was made in tickets/ DM-14734 -postfix branch and pushed to fix this typo. David Shupe
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
David Shupe
made changes -
If you can, I would suggest remembering the most recent pan() command as well. Even though we don't have an optimized API yet (see DM-14736) for choosing the center point at the time of initial display/ mtv(), this will enable client-side code to be rewritten only once, now, to take advantage of the optimizations.