Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14739

Reproduce the results of DMTN-037 using simulated data based on the stackified DCR code

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      AP F18-2, AP F18-3, AP F18-5, AP F18-6
    • Team:
      Alert Production

      Description

      Attempt to reproduce results DMTN-037 based on the stackified DCR code (DM-9613). If there are any changes, account for them and fix regressions or update the technote to reflect improvements.

      (Spend no more than a couple of days on this; if you find major discrepancies which need more work, file tickets to investigate them.)

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -

            I have updated DMTN-037 with new figures based on using the new stackified DCR modeling code. The updated version can be viewed here: https://dmtn-037.lsst.io/v/DM-14739/index.html , and the diff here: https://github.com/lsst-dm/dmtn-037/pull/5

            For this ticket, I focused on simply recreating the figures from the original tech note, and only modifying the text slightly to match. I could of course also do a full overhaul of the text, but I think that would belong on a new ticket.

            Show
            sullivan Ian Sullivan added a comment - I have updated DMTN-037 with new figures based on using the new stackified DCR modeling code. The updated version can be viewed here: https://dmtn-037.lsst.io/v/DM-14739/index.html , and the diff here: https://github.com/lsst-dm/dmtn-037/pull/5 For this ticket, I focused on simply recreating the figures from the original tech note, and only modifying the text slightly to match. I could of course also do a full overhaul of the text, but I think that would belong on a new ticket.
            Hide
            swinbank John Swinbank added a comment - - edited

            Sorry for the delay in getting to this!

            I agree with your interpretation of the ticket and that substantial overhaul of the text belongs elsewhere.

            I left a couple of comments on GitHub, but I don't think any of them are hard to address. Overall, this looks good to me.

            Show
            swinbank John Swinbank added a comment - - edited Sorry for the delay in getting to this! I agree with your interpretation of the ticket and that substantial overhaul of the text belongs elsewhere. I left a couple of comments on GitHub, but I don't think any of them are hard to address. Overall, this looks good to me.
            Hide
            sullivan Ian Sullivan added a comment -

            I've edited the text and added a few explanatory footnotes. John Swinbank please take a quick look at the changes, and unless I hear otherwise I will plan to merge them tomorrow. Note that the "Latest revision" date is set by the last merge to master, so that will only update after it's merged.

            Show
            sullivan Ian Sullivan added a comment - I've edited the text and added a few explanatory footnotes. John Swinbank please take a quick look at the changes, and unless I hear otherwise I will plan to merge them tomorrow. Note that the "Latest revision" date is set by the last merge to master , so that will only update after it's merged.
            Hide
            swinbank John Swinbank added a comment -

            Looks great to me! Thanks Ian.

            Show
            swinbank John Swinbank added a comment - Looks great to me! Thanks Ian.

              People

              • Assignee:
                sullivan Ian Sullivan
                Reporter:
                swinbank John Swinbank
                Reviewers:
                John Swinbank
                Watchers:
                Ian Sullivan, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel