Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14740

Stop using ndarray::EigenView indirectly in C++ code

    Details

    • Templates:
    • Story Points:
      4
    • Team:
      Alert Production

      Description

      Use the ndarray::Array functions added in DM-14728 instead of ndarray::Array::asEigen to eliminate our use of ndarray::EigenView in our C++ code.

      Warning: these new functions return Eigen::Map, which does not use reference counting to manage memory, so be careful when converting old code. In most instances nothing needs to change as the Eigen object will to out of scope before the ndarray array. However, there are likely to be a few bits of code that will require non-trivial changes in order to avoid memory leaks (e.g. if the Eigen Map is passed around or stored); in that case we have to copy the array data or keep the data as an ndarray::Array and delay extracting the Eigen version until deeper in the code.

      Note that updating our pybind11 wrappers will be done on a different ticket.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  rowen Russell Owen
                  Reporter:
                  rowen Russell Owen
                  Reviewers:
                  Krzysztof Findeisen
                  Watchers:
                  Jim Bosch, Krzysztof Findeisen, Russell Owen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel