Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14742

Let ap_verify run ap_pipe with dataset-specific configs

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP F18-1, AP F18-2
    • Team:
      Alert Production

      Description

      lsst.ap.verify.DatasetIngestTask currently accepts configs from a dataset, allowing for dataset-specific file masks and similar features. It would be useful for ap_verify's calls to ApPipeTask to have the same capability, so that dataset-specific options (for example, the distinction between "deep" and "goodSeeing" templates) can be set for the instance(s) of ApPipeTask created by ap_verify.

      Unlike DatasetIngestTask, ApPipeTask does not need special support for obs-specific configs as it already provides them automatically as a CmdLineTask.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            Hi Jim Bosch, could you please review this 300-line change? Thanks!

            The scope ended up creeping a bit beyond the original issue; in particular, I added unit tests for the entire pipeline_driver module and did have to write custom code to handle obs package overrides.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Hi Jim Bosch , could you please review this 300-line change? Thanks! The scope ended up creeping a bit beyond the original issue; in particular, I added unit tests for the entire pipeline_driver module and did have to write custom code to handle obs package overrides.
            Hide
            jbosch Jim Bosch added a comment -

            Review complete.  Only very minor comments in the PR.

             

            Show
            jbosch Jim Bosch added a comment - Review complete.  Only very minor comments in the PR.  
            Hide
            krzys Krzysztof Findeisen added a comment -

            Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks!

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Jim Bosch
                Watchers:
                Eric Bellm, Jim Bosch, Krzysztof Findeisen, Meredith Rawls
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel