Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14764

Move kwargs check to before loading dataset

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: validate_drp
    • Labels:
      None

      Description

      Move the check for the instrument and dataset_repo_url to before the loading of the dataset. If we're going to fail, then fail quickly, instead of failing after having read in 100 GB of catalog data.

      Notes:
      I'd like to rework this logic completely, but I'll do that in a separate ticket and after more discussion. -> DM-14765

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-14765 Allow validateDrp to run w/o instrument, dataset_repo_url

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            wmwood-vasey Michael Wood-Vasey added a comment -

            Trivial review. Move instrument, dataset_repo_url check to before loading all of the data.

            Passes Jenkins.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Trivial review. Move instrument, dataset_repo_url check to before loading all of the data. Passes Jenkins.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Seems fine.

            Show
            krughoff Simon Krughoff added a comment - Seems fine.
            Hide
            Permalink
            wmwood-vasey Michael Wood-Vasey added a comment -

            Merged to master.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.
            Hide
            Permalink
            wmwood-vasey Michael Wood-Vasey added a comment -

            Merged to master.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

              People

              Assignee:
              wmwood-vasey Michael Wood-Vasey
              Reporter:
              wmwood-vasey Michael Wood-Vasey
              Reviewers:
              Simon Krughoff
              Watchers:
              Michael Wood-Vasey, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.