Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14764

Move kwargs check to before loading dataset

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: validate_drp
    • Labels:
      None

      Description

      Move the check for the instrument and dataset_repo_url to before the loading of the dataset. If we're going to fail, then fail quickly, instead of failing after having read in 100 GB of catalog data.

      Notes:
      I'd like to rework this logic completely, but I'll do that in a separate ticket and after more discussion. -> DM-14765

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-14765 Allow validateDrp to run w/o instrument, dataset_repo_url

          • Done

            Activity

            Ascending order - Click to sort in descending order
            wmwood-vasey Michael Wood-Vasey created issue -
            wmwood-vasey Michael Wood-Vasey made changes -
            Field Original Value New Value
            Risk Score 0
            wmwood-vasey Michael Wood-Vasey made changes -
            Story Points 0.25
            Team SQuaRE [ 10302 ]
            wmwood-vasey Michael Wood-Vasey made changes -
            Story Points 0.25 0
            wmwood-vasey Michael Wood-Vasey made changes -
            Link This issue relates to DM-14765 [ DM-14765 ]
            wmwood-vasey Michael Wood-Vasey made changes -
            Description Move the check for the {{instrument}} and {{dataset_repo_url}} to before the loading of the dataset. If we're going to fail, then fail quickly, instead of failing after having read in 100 GB of catalog data.

            Notes:
            I'd like to rework this logic completely, but I'll do that in a separate ticket and after more discussion.             		Move the check for the {{instrument}} and {{dataset_repo_url}} to before the loading of the dataset. If we're going to fail, then fail quickly, instead of failing after having read in 100 GB of catalog data.

            Notes:
            I'd like to rework this logic completely, but I'll do that in a separate ticket and after more discussion. -> DM-14765
            wmwood-vasey Michael Wood-Vasey made changes -
            Status To Do [ 10001 ] In Review [ 10004 ]
            krughoff Simon Krughoff made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            wmwood-vasey Michael Wood-Vasey made changes -
            Status Reviewed [ 10101 ] Reviewed [ 10101 ]
            wmwood-vasey Michael Wood-Vasey made changes -
            Story Points 0 0.25
            wmwood-vasey Michael Wood-Vasey made changes -
            Epic Link DM-5510 [ 23343 ]
            wmwood-vasey Michael Wood-Vasey made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              wmwood-vasey Michael Wood-Vasey
              Reporter:
              wmwood-vasey Michael Wood-Vasey
              Reviewers:
              Simon Krughoff
              Watchers:
              Michael Wood-Vasey, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.