Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14764

Move kwargs check to before loading dataset

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • validate_drp
    • None

    Description

      Move the check for the instrument and dataset_repo_url to before the loading of the dataset. If we're going to fail, then fail quickly, instead of failing after having read in 100 GB of catalog data.

      Notes:
      I'd like to rework this logic completely, but I'll do that in a separate ticket and after more discussion. -> DM-14765

      Attachments

        Issue Links

          Activity

            Trivial review. Move instrument, dataset_repo_url check to before loading all of the data.

            Passes Jenkins.

            wmwood-vasey Michael Wood-Vasey added a comment - Trivial review. Move instrument, dataset_repo_url check to before loading all of the data. Passes Jenkins.

            Seems fine.

            krughoff Simon Krughoff (Inactive) added a comment - Seems fine.

            Merged to master.

            wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

            Merged to master.

            wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

            People

              wmwood-vasey Michael Wood-Vasey
              wmwood-vasey Michael Wood-Vasey
              Simon Krughoff (Inactive)
              Michael Wood-Vasey, Simon Krughoff (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.