Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:2
-
Team:SQuaRE
Description
The Job verify infrastructure wants to record an 'instrument' and 'dataset_repo_url'. This is a requirement of ingesting into SQUASH. It's not necessary for the logic of the actual evaluation of the data. Additionally, a simple version of this information already exists in the Butler repo object.
I propose to set the default behavior so that instrument is read from the Butler repo mapper and dataset_repo_url is set to the filepath of the dataset. Users of validate_drp can set these to be other values, but we shouldn't require that all uses of validateDrp.py specify a dummy instrument and dataset_repo_url value just to run.
The spirit of this ticket is to make validateDrp.py just run and do reasonable things with the information given. If the user desires to associate additional or more specific information with the Job object, that's fine, but shouldn't be required.
Attachments
Issue Links
- relates to
-
- Done
Activity
Would it be possible to rework verify_metrics to have a default that then could be overridden on a per-instrument basis if necessary?
Michael Wood-Vasey
added a comment - Would it be possible to rework verify_metrics to have a default that then could be overridden on a per-instrument basis if necessary? I think we probably could rework verify_metrics.
Given that I'm the one grumbling about it, I'm certainly happy to work on this.
Michael Wood-Vasey
added a comment - Given that I'm the one grumbling about it, I'm certainly happy to work on this. Merged to master.
And then fixed in tickets/DM-14928
Michael Wood-Vasey
added a comment - Merged to master.
And then fixed in tickets/ DM-14928 
Am I correct that a new set of specs has to be written now for obs_lsstSim and obs_lsstCam before we can run validateDrp.py on output from these, even thought they're identical to the CFHT, DECam, and HSC specifications.