Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14767

fix photometric error calculation

    XMLWordPrintable

    Details

      Description

      While starting to implement the magnitude based photometric model (DM-14574), I noticed that my implementation of the error model for the flux based model was incorrect. I'm going to fix that now and see if it helps the fitter.

        Attachments

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          The work for this was done on DM-14574, but I've rebased it over to here to make the review of this and that easier.

          Show
          Parejkoj John Parejko added a comment - The work for this was done on DM-14574 , but I've rebased it over to here to make the review of this and that easier.
          Hide
          Parejkoj John Parejko added a comment -

          Jim Bosch: do you think you would be able to review this? I extracted the code that incorporated the model uncertainty from DM-14574, to make the reviews less onerous; some of the preparatory code for that is still in this ticket, because I couldn't separate the cleanups from the actual fixes.

          The bug in the photometry uncertainty calculation that I thought I'd found turns out not to exist (both the simple and constrained models end up with the flux and fluxErr calculations taking exactly the same form). Instead, I added the model uncertainty, which we should be including as part of the chi2. It doesn't shift the test calculations much, and it doesn't seem to help the HSC PDR1 data, but we might as well get it right.

          Show
          Parejkoj John Parejko added a comment - Jim Bosch : do you think you would be able to review this? I extracted the code that incorporated the model uncertainty from DM-14574 , to make the reviews less onerous; some of the preparatory code for that is still in this ticket, because I couldn't separate the cleanups from the actual fixes. The bug in the photometry uncertainty calculation that I thought I'd found turns out not to exist (both the simple and constrained models end up with the flux and fluxErr calculations taking exactly the same form). Instead, I added the model uncertainty, which we should be including as part of the chi2. It doesn't shift the test calculations much, and it doesn't seem to help the HSC PDR1 data, but we might as well get it right.
          Show
          Parejkoj John Parejko added a comment - - edited Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28120/pipeline
          Hide
          jbosch Jim Bosch added a comment -

          What problem is this trying to solve now?  The only uncertainty in the chi^2 should be the measurement errors in the MeasuredStars; models don't have uncertainties.  The best-fit model parameters will have uncertainties, of course, and those need to be propagated when calibrating fluxes, but that should not affect the fit itself.

          Show
          jbosch Jim Bosch added a comment - What problem is this trying to solve now?  The only uncertainty in the chi^2 should be the measurement errors in the MeasuredStars; models don't have uncertainties.  The best-fit model parameters will have uncertainties, of course, and those need to be propagated when calibrating fluxes, but that should not affect the fit itself.
          Hide
          Parejkoj John Parejko added a comment -

          Marking Invalid.

          After discussion with Jim Bosch, we decided that this change is not correct: the model uncertainty comes from the covariance of the measured uncertainties, so it is already incorporated in the fitter.

          Show
          Parejkoj John Parejko added a comment - Marking Invalid. After discussion with Jim Bosch , we decided that this change is not correct: the model uncertainty comes from the covariance of the measured uncertainties, so it is already incorporated in the fitter.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, John Parejko, John Swinbank
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: