Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14786

Implement ConstrainedMagnitude model

    XMLWordPrintable

    Details

      Description

      I'm going to have DM-14574 go into review so that the design for the Simple model for the magnitude-based photometry fitter is happy, before I dig into the more complicated Constrained model. So, 14574 becomes "implement the simple model" and this ticket is then to implement the constrained model.

        Attachments

          Issue Links

            Activity

            Hide
            dtaranu Dan Taranu added a comment -

            Okay.

            Show
            dtaranu Dan Taranu added a comment - Okay.
            Hide
            Parejkoj John Parejko added a comment -

            Dan Taranu Thank you for the review. I believe I responded to all your concerns, and added a number of new tests along the way. Can you please look at the two "post review" commits plus the new constructor test and see if they satisfy your concerns?

            New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28426/pipeline

            Show
            Parejkoj John Parejko added a comment - Dan Taranu Thank you for the review. I believe I responded to all your concerns, and added a number of new tests along the way. Can you please look at the two "post review" commits plus the new constructor test and see if they satisfy your concerns? New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28426/pipeline
            Hide
            dtaranu Dan Taranu added a comment -

            Looks good to go.

            Show
            dtaranu Dan Taranu added a comment - Looks good to go.
            Hide
            Parejkoj John Parejko added a comment -
            Show
            Parejkoj John Parejko added a comment - One final jenkins run, after rebasing to master: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28454/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the big review, and for looking over my updates.

            Squashed, merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the big review, and for looking over my updates. Squashed, merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Dan Taranu
              Watchers:
              Dan Taranu, Dominique Boutigny, Jim Bosch, John Parejko, John Swinbank, Pierre Astier
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: