Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14831

Update Butler makeView to trigger view creation only on related tables

    Details

      Description

      Review comment on DM-14811: "This may be out of scope for this issue, but since we know which tables any of our views will depend on, could we make the creation of just those tables trigger view creation?". The answer is yes, but it is tricky because:

      • Schema.addTable doesn't know about the relations.
      • SQLAlchemy DDLEvents trigger on single entities only.

      For the latter a solution would be to trigger view creation / dropping on all relations. This may duplicate some calls, but (in case of drop in particular) is probably the right thing to do.
      This still needs a solution to the first point, developing that is part of this ticket.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            This was created in response to a nice-to-have comment in a previous review, and doesn't look like something we actually need.

            Show
            jbosch Jim Bosch added a comment - This was created in response to a nice-to-have comment in a previous review, and doesn't look like something we actually need.

              People

              • Assignee:
                Unassigned
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Watchers:
                Jim Bosch, Pim Schellart [X] (Inactive), Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel