Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14840

Make mask transparency and color "sticky" in display_firefly

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, display_firefly
    • Labels:
      None
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      SUIT Sprint 2018-06, SUIT Sprint 2018-07, SUIT Sprint 2018-08
    • Team:
      Science User Interface

      Description

      afw.display provides methods for setting mask plane colors and transparencies. These should be "sticky" in the display_firefly backend, meaning that once they are set for a Display object, they should be applied when an image is sent again to that display.

      The display_firefly backend also needs to ignore masks whose color is set to "ignore" or "IGNORE". 

      Related to this, afw.display provides setDefaultMaskTransparency and setDefaultMaskPlaneColor which are used when Display instances are created. Fix a small bug in setDefaultMaskTransparency and verify that both of these work with the display_firefly backend.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14837 Firefly improvements to intro-with-globular notebook

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            shupe David Shupe created issue -
            shupe David Shupe made changes -
            Field Original Value New Value
            Epic Link DM-14499 [ 84664 ]
            shupe David Shupe made changes -
            Link This issue relates to DM-14837 [ DM-14837 ]
            shupe David Shupe made changes -
            Risk Score 0
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2018-06 [ 705 ] SUIT Sprint 2018-06, SUIT Sprint 2018-07 [ 705, 736 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2018-06, SUIT Sprint 2018-07 [ 705, 736 ] SUIT Sprint 2018-06, SUIT Sprint 2018-07, SUIT Sprint 2018-08 [ 705, 736, 738 ]
            shupe David Shupe made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            shupe David Shupe added a comment -

            Hopefully this is a short review, code only.

            Show
            shupe David Shupe added a comment - Hopefully this is a short review, code only.
            shupe David Shupe made changes -
            Reviewers Hsin-Fang Chiang [ hchiang2 ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            The code changes look good to me. 

            Show
            hchiang2 Hsin-Fang Chiang added a comment - The code changes look good to me. 
            hchiang2 Hsin-Fang Chiang made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            shupe David Shupe made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-14499 [ 84664 ] DM-8771 [ 28610 ]

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              David Shupe, Hsin-Fang Chiang, Jim Bosch, Robert Lupton, Simon Krughoff, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.