Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14845

Uninitialized array in afw/tests/test_tableArchives.cc

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Team:
      Architecture

      Description

      The av2 array in the IncompatibleSchemas test case in afw/tests/test_tableArchives.cc lines 423-426 is not initialized. After it is created, the av1 array is (re)-initialized (incorrectly) due to a couple of typos. This leads to unspecified behavior in the subsequent round-trip test.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-12763 afw test_testTableArchives has uninitialized memory

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Credit to Eli Rykoff for spotting the problem in the code.

            Show
            ktl Kian-Tat Lim added a comment - Credit to Eli Rykoff for spotting the problem in the code.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Fix implemented; Jenkins 28082 running.

            Show
            ktl Kian-Tat Lim added a comment - Fix implemented; Jenkins 28082 running.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Looks like I tripped over one of these before: DM-12763

            Are there any other similar uninitialized values in this test file?

            Show
            Parejkoj John Parejko added a comment - Looks like I tripped over one of these before: DM-12763 Are there any other similar uninitialized values in this test file?
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Jenkins is past afw, and I don't see how a test code change could affect the build of any other package, so I think this is ready for eagle-eyed review.

            Show
            ktl Kian-Tat Lim added a comment - Jenkins is past afw, and I don't see how a test code change could affect the build of any other package, so I think this is ready for eagle-eyed review.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Looks good.

            Show
            erykoff Eli Rykoff added a comment - Looks good.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Merged in dd706d.

            Show
            ktl Kian-Tat Lim added a comment - Merged in dd706d.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            John Parejko I looked fairly carefully through the rest of the code in this file and didn't see anything else problematic. More use could I think be made of std::make_shared to reduce verbosity, but at least there are no obvious typos.

            Show
            ktl Kian-Tat Lim added a comment - John Parejko I looked fairly carefully through the rest of the code in this file and didn't see anything else problematic. More use could I think be made of std::make_shared to reduce verbosity, but at least there are no obvious typos.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Kian-Tat Lim: thanks for checking.

            Show
            Parejkoj John Parejko added a comment - Kian-Tat Lim : thanks for checking.

              People

              Assignee:
              ktl Kian-Tat Lim
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, Kian-Tat Lim
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.