Some mostly-fairly-minor comments on the code in meas_astrom at https://github.com/lsst/meas_astrom/pull/106. In addition to those, it would be great to clean up the history by squashing — per my confusion above, the unsquashed history makes it hard to understand what's going on.
Aside from that, the changes in obs_cfht and obs_subaru look fine.
Two naive questions:
- Why aren't changes necessary in other packages? It looks as though Jointcal, pipe_tasks and a few other packages are referring to OptimisticB only config parameters — why don't they need updating? Am I missing something obvious?
- I know you've demonstrated that PPMb performs well in earlier tests, but do we know exactly what impact merging this will have on the existing metrics that are being tracked in SQuaSH?