Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:AP F18-2
-
Team:Alert Production
Description
Many of our afw pybind11 wrappers are rejected by pybind11 2.2.3. In a few cases these appear to be actual errors, e.g. see http://pybind11.readthedocs.io/en/stable/upgrade.html and https://github.com/pybind/pybind11/issues/1052 but in most cases it appears to be that pybind 2.2.3 is pickier than 2.1.1.
This ticket is intended to make afw compatible with pybind11 2.2.3 while retaining compatibility with 2.1.1. Thus it will build with warnings under pybind11 2.2.3, and some modules show warnings when imported.
Attachments
Issue Links
- blocks
-
DM-14828 Upgrade pybind11 to 2.2.3
- Done
Do you have time to look at this Pim Schellart [X], or some subset of it? In particular I would be very grateful if you could at least look at the first 4 commits, which fix errors and incompatibilities with pybind11 2.2. (A later commit that adds imports to pybind11 modules also fixes incompatibilities, but is less interesting).
I also made the afw wrappers consistent (or mostly consistent) with our other packages, e.g. using addUnderscore=False in SConscript files, using a subdirectory and a fooContinued.py module when a class is continued and using continueClass. I left fooLib.py modules alone except in one or two cases where it was clearly safe to remove them. If you only have time to review the other commits I can pass that one off to somebody else.