Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14878

generateAcronyms.py seems to not complain on missing acronym

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Systems Engineering
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Architecture

      Description

      I noticed that the acronym DBA did not show up in my generated acronyms. There is a lot of output which is not needed so it may have complained.

      When I added it to myacronyms.txt it showed up fine .. now I wonder if I am missing others ...

      Tim Jenness I may try to look at this next week unless its just too verbose output

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          The code doesn't try to find all possible acronyms. It specifically tries to match the list of known acronyms against the supplied text. It does this with a single regular expression rather than analyzing each line for a collection of upper case characters. It wouldn't be too hard to flip things round to extract all things that look like an acronym from the text and then compare with the acronym list, but it would need us to agree what an acronym is since some seem to have lower case characters so \b[A-Z][A-Z\&][A-Z]\b isn't sufficient.

          Show
          tjenness Tim Jenness added a comment - The code doesn't try to find all possible acronyms. It specifically tries to match the list of known acronyms against the supplied text. It does this with a single regular expression rather than analyzing each line for a collection of upper case characters. It wouldn't be too hard to flip things round to extract all things that look like an acronym from the text and then compare with the acronym list, but it would need us to agree what an acronym is since some seem to have lower case characters so \b [A-Z] [A-Z\&] [A-Z] \b isn't sufficient.
          Hide
          womullan Wil O'Mullane added a comment -

          ah ok .. I remember you telling me about the match expression , I had not twigged that would mean no warning. The original Gaia one looks for any UPPERCASE words and reported them - this could be a separate.

          Show
          womullan Wil O'Mullane added a comment - ah ok .. I remember you telling me about the match expression , I had not twigged that would mean no warning. The original Gaia one looks for any UPPERCASE words and reported them - this could be a separate.
          Hide
          tjenness Tim Jenness added a comment -

          I've made some fixes. I now scan for non-standard acronyms (R&D, FoV, arcsec etc) as a regex, but then I scan the text for acronyms defined as 2 or more upper case characters and compare with the list of known acronyms. Undefined acronyms are now reported.

          Show
          tjenness Tim Jenness added a comment - I've made some fixes. I now scan for non-standard acronyms (R&D, FoV, arcsec etc) as a regex, but then I scan the text for acronyms defined as 2 or more upper case characters and compare with the list of known acronyms. Undefined acronyms are now reported.
          Hide
          womullan Wil O'Mullane added a comment -

          ok NOW i see loads of undefined acronyms !

          Show
          womullan Wil O'Mullane added a comment - ok NOW i see loads of undefined acronyms !

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              womullan Wil O'Mullane
              Reviewers:
              Wil O'Mullane
              Watchers:
              Tim Jenness, Wil O'Mullane
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel