Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14915

rewrite_shebang is not run in ctrl_orca

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ctrl_orca
    • Labels:
      None

      Description

      For some reasons ctrl_orca is missing the bin folder, at least in recent releases (e.g. docker images v15, w_2018_23, ...). Usually a bin folder is created for packages with a bin.src folder during the build process. But the bin folder is not made in ctrl_orca; rewrite_shebang is not run in the build process. This is also true in lsstsw build and the shared stack in /software on LSST machines. Manually scons-ing it works.

        Attachments

          Activity

          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Do you mind reviewing this?

          I'm un-commenting two lines that got commented out during the pybind11 transition (DM-8467). DM-8873 suggests that it's pybind11 compatible. This might not solve all problems related to this, but should be a start, and I will then check the next weekly release docker image (unfortunately I don't know how to test this otherwise. Could also be something in the release process?).

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Do you mind reviewing this? I'm un-commenting two lines that got commented out during the pybind11 transition ( DM-8467 ). DM-8873 suggests that it's pybind11 compatible. This might not solve all problems related to this, but should be a start, and I will then check the next weekly release docker image (unfortunately I don't know how to test this otherwise. Could also be something in the release process?).
          Show
          hchiang2 Hsin-Fang Chiang added a comment - Jenkins is in progress, green in centos so far: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28126/pipeline/
          Hide
          spietrowicz Steve Pietrowicz added a comment -

          Looks fine

          Show
          spietrowicz Steve Pietrowicz added a comment - Looks fine
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Thanks!

          Merged after another successful Jenkins run.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Thanks! Merged after another successful Jenkins run .
          Hide
          swinbank John Swinbank added a comment -

          Hsin-Fang Chiang — does “merged” mean we can close the ticket?

          Show
          swinbank John Swinbank added a comment - Hsin-Fang Chiang — does “merged” mean we can close the ticket?
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Confirmed that the bin folder was made in the d_2018_07_05 image (while it was not made in d_2018_07_03)

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Confirmed that the bin folder was made in the  d_2018_07_05 image (while it was not made in d_2018_07_03 )

            People

            Assignee:
            hchiang2 Hsin-Fang Chiang
            Reporter:
            hchiang2 Hsin-Fang Chiang
            Reviewers:
            Steve Pietrowicz
            Watchers:
            Hsin-Fang Chiang, John Swinbank, Steve Pietrowicz, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.