Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14986

Update pybind11 documentation for Eigen

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      As of DM-14834 we handling Eigen differently in pybind11 wrappers: wrappers should now #include pybind11/eigen.h, which is the standard pybind11 way to do it.

      Update our pybind11 documentation accordingly.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-14834 Use pybind11's native Eigen wrapping instead of ndarray EigenView

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I know you are very busy, but this is a tiny change and I hope you may be able to find time for it or suggest another reviewer.

            Show
            rowen Russell Owen added a comment - I know you are very busy, but this is a tiny change and I hope you may be able to find time for it or suggest another reviewer.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Happy to do small things at it makes me feel like I'm making progress on the to-do list.  PR?

            Show
            jbosch Jim Bosch added a comment - Happy to do small things at it makes me feel like I'm making progress on the to-do list.  PR?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good!

            Show
            jbosch Jim Bosch added a comment - Looks good!

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: