Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-14997

Implement RFC-498: homogenize naming of calibration flags

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      6
    • Sprint:
      DRP F18-2, DRP F18-3
    • Team:
      Data Release Production

      Description

      We currently have the following set of names for the calib_* flags that get propagated to source catalogs:

      • calib_detected
      • calib_psfCandidate
      • calib_psfUsed
      • calib_psf_reserved (changed from calib_psfReserved on DM-12207 in this commit)
      • calib_astrometryUsed
      • calib_photometry_used (changed from calib_photometryUsed on DM-12207, in this commit)
      • calib_photometry_reserved (changed from calib_photometryReserved on DM-12207 in this commit)

      I.e. there is a mixture of underscore and camelCase for the third (final) "descriptor", making it difficult to remember which standard to use when trying to select on a given flag.  These should all be homogenized and, given the recent changes in this direction noted above, I believe the preferred choice is the underscore standard.

      A change in the flag names will affect any current user scripts that select on these flags.  To prevent scripts from breaking, it may be desirable to set a (temporary?) alias (although this was not done along with the DM-12207 changes and there was no uproar that I'm aware of).

        Attachments

          Issue Links

            Activity

            lauren Lauren MacArthur created issue -
            lauren Lauren MacArthur made changes -
            Field Original Value New Value
            Epic Link DM-14405 [ 79812 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-12207 [ DM-12207 ]
            lauren Lauren MacArthur made changes -
            Risk Score 0
            lauren Lauren MacArthur made changes -
            Watchers John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad [ John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad ] Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad [ Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad ]
            lauren Lauren MacArthur made changes -
            Link This issue blocks DM-11974 [ DM-11974 ]
            lauren Lauren MacArthur made changes -
            Link This issue blocks DM-11866 [ DM-11866 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-14998 [ DM-14998 ]
            lauren Lauren MacArthur made changes -
            Link This issue is triggered by RFC-498 [ RFC-498 ]
            lauren Lauren MacArthur made changes -
            Summary Homogenize naming of calibration flags Implement RFC-498: homogenize naming of calibration flags
            lauren Lauren MacArthur made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            lauren Lauren MacArthur made changes -
            Sprint DRP F18-2 [ 756 ]
            Story Points 4
            Assignee Lauren MacArthur [ lauren ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-15109 [ DM-15109 ]
            lauren Lauren MacArthur made changes -
            Reviewers John Parejko [ parejkoj ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Parejkoj John Parejko made changes -
            Risk Score 0 1
            yusra Yusra AlSayyad made changes -
            Sprint DRP F18-2 [ 756 ] DRP F18-2, DRP F18-3 [ 756, 768 ]
            yusra Yusra AlSayyad made changes -
            Risk Score 1 0
            lauren Lauren MacArthur made changes -
            Story Points 4 6
            lauren Lauren MacArthur made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              John Parejko
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.