Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:6
-
Epic Link:
-
Sprint:DRP F18-2, DRP F18-3
-
Team:Data Release Production
Description
We currently have the following set of names for the calib_* flags that get propagated to source catalogs:
- calib_detected
- calib_psfCandidate
- calib_psfUsed
- calib_psf_reserved (changed from calib_psfReserved on
DM-12207in this commit) - calib_astrometryUsed
- calib_photometry_used (changed from calib_photometryUsed on
DM-12207, in this commit) - calib_photometry_reserved (changed from calib_photometryReserved on
DM-12207in this commit)
I.e. there is a mixture of underscore and camelCase for the third (final) "descriptor", making it difficult to remember which standard to use when trying to select on a given flag. These should all be homogenized and, given the recent changes in this direction noted above, I believe the preferred choice is the underscore standard.
A change in the flag names will affect any current user scripts that select on these flags. To prevent scripts from breaking, it may be desirable to set a (temporary?) alias (although this was not done along with the DM-12207 changes and there was no uproar that I'm aware of).
Attachments
Issue Links
- blocks
-
DM-11866 Propagate astrometry and photometry visit calibration flags to coadds
- Done
-
DM-11974 Add calibUsed-only qa plots to CoaddAnalysis
- Done
- is triggered by
-
RFC-498 Homogenize naming of calibration flags
- Implemented
- relates to
-
DM-14998 Document schema naming conventions
- Done
-
DM-15109 Adapt pipe_analysis to RFC-498 implementation
- Done
-
DM-12207 Add color selection for photocal
- Done
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Risk Score | 0 |
Watchers | John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad [ John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad ] | Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad [ Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price, Yusra AlSayyad ] |
Summary | Homogenize naming of calibration flags |
Implement |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Sprint | DRP F18-2 [ 756 ] | |
Story Points | 4 | |
Assignee | Lauren MacArthur [ lauren ] |
Reviewers | John Parejko [ parejkoj ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Risk Score | 0 | 1 |
Sprint | DRP F18-2 [ 756 ] | DRP F18-2, DRP F18-3 [ 756, 768 ] |
Risk Score | 1 | 0 |
Story Points | 4 | 6 |
Resolution | Done [ 10000 ] | |
Status | Reviewed [ 10101 ] | Done [ 10002 ] |