Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15011

implement separate Visit and Chip fitting for photometry

    XMLWordPrintable

    Details

      Description

      While doing additional testing of DM-14510, I noticed that the astrometry model fit could be thrown off by doing a line search during the initialization DistortionVisit fit step. This reminded me that I haven't implemented the separate "Visit" and "Chip" fitting option for Photometry: it may help things by pushing the toward the global minimum on the first step (as it does in astrometry). It should be very easy to implement.

        Attachments

          Issue Links

          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14510 Implement line search

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8046 whatToFit should use an enumlist/bitfield, not string parsing

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen: do you mind taking on this medium sized review (~200 lines)?

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen : do you mind taking on this medium sized review (~200 lines)?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28167/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28167/pipeline
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I'm a bit worried about how you're dealing with the "Chip vs. Visit" mode, particularly the implied difference in how fitting of PhotometryMappingBase vs. PhotometryMapping is handled. Can you take a look at the GitHub comments?

            Show
            krzys Krzysztof Findeisen added a comment - I'm a bit worried about how you're dealing with the "Chip vs. Visit" mode, particularly the implied difference in how fitting of PhotometryMappingBase vs. PhotometryMapping is handled. Can you take a look at the GitHub comments?
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            The new version looks good.

            Show
            krzys Krzysztof Findeisen added a comment - The new version looks good.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review and for the subsequent discussion.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review and for the subsequent discussion. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.