Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15038

Update TransformMap to use ast::FrameDict

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw

      Description

      lsst::afw::cameraGeom::TransformMap presently uses ast::FrameSet internally and keeps track of frame indices itself. However, ast::FrameDict (which was added after TransformMap was written) does all this itself, so simplify the TransformMap code by using FrameDict internally.

        Attachments

          Activity

          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Epic Link DM-14447 [ 80385 ]
          rowen Russell Owen made changes -
          Risk Score 0
          rowen Russell Owen made changes -
          Sprint AP F18-2 [ 747 ]
          Hide
          rowen Russell Owen added a comment -

          There is a trade-off required to do this: the coordinate system name and detector name must be combined into a single string that becomes the key used by FrameDict. Thus we need a separator that cannot be used by either the coordinate system name or the detector name and a bit of trivial code to combine them. This is only a minor nuisance, as we have to document the separator. However, TransformMap can return a list of supported CameraSys, so we also must be able to efficiently split the keys into system name and detector name. This is a bit more work, but C++ does provide appropriate calls. (We could avoid this by keeping a separate map of key: CameraSys, but that adds sufficient complexity that I do not think it would be worth making the proposed change.)

          Show
          rowen Russell Owen added a comment - There is a trade-off required to do this: the coordinate system name and detector name must be combined into a single string that becomes the key used by FrameDict . Thus we need a separator that cannot be used by either the coordinate system name or the detector name and a bit of trivial code to combine them. This is only a minor nuisance, as we have to document the separator. However, TransformMap can return a list of supported CameraSys , so we also must be able to efficiently split the keys into system name and detector name. This is a bit more work, but C++ does provide appropriate calls. (We could avoid this by keeping a separate map of key: CameraSys , but that adds sufficient complexity that I do not think it would be worth making the proposed change.)
          swinbank John Swinbank made changes -
          Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
          swinbank John Swinbank made changes -
          Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
          rowen Russell Owen made changes -
          Assignee Russell Owen [ rowen ]
          swinbank John Swinbank made changes -
          Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
          swinbank John Swinbank made changes -
          Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
          swinbank John Swinbank made changes -
          Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
          swinbank John Swinbank made changes -
          Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
          swinbank John Swinbank made changes -
          Epic Link DM-24339 [ 433026 ] DM-25139 [ 435257 ]
          swinbank John Swinbank made changes -
          Epic Link DM-25139 [ 435257 ] DM-26810 [ 439762 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-26810 [ 439762 ] DM-27906 [ 442554 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-27906 [ 442554 ] DM-29214 [ 459218 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-29214 [ 459218 ] DM-30436 [ 504824 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-30436 [ 504824 ] DM-30501 [ 510159 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-30501 [ 510159 ] DM-30502 [ 510160 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-30502 [ 510160 ] DM-30506 [ 510172 ]
          horvat Nikolina Horvat made changes -
          Epic Link DM-30506 [ 510172 ] DM-34931 [ 1598492 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-34931 [ 1598492 ] DM-36006 [ 1997396 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-36006 [ 1997396 ] DM-36522 [ 2254239 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-36522 [ 2254239 ] DM-36523 [ 2254240 ]

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            rowen Russell Owen
            Watchers:
            Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Jenkins

                No builds found.