Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15044

Seemingly Large demo change with bleeding edge pipelines build

    Details

      Description

      In testing a bleeding edge conda install on my Mac, which includes numpy 1.14, astropy 3.0.3 and matplotlib 2.2.2, lsst_distrib builds fine but when I run lsst_dm_stack_demo I get nearly 100,000 failures, 8000 of which are failing at the 1e-06 level. I have no idea whether this is reasonable but it sounds very large. The detected-sources txt file is attached.

      I have not tested ci_hsc or lsst_ci. I will see if I can run lsst_ci on this system.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            lsst_ci passes.

            Show
            tjenness Tim Jenness added a comment - lsst_ci passes.
            Hide
            tjenness Tim Jenness added a comment -

            ci_hsc also passes, so the variation is only picked up in demo.

            Show
            tjenness Tim Jenness added a comment - ci_hsc also passes, so the variation is only picked up in demo.
            Hide
            tjenness Tim Jenness added a comment -

            After some discussion on Slack, Michael Wood-Vasey pointed out that the problem is that the demo text files are written using default stringification, rather than constraining the formatting to a specific number of decimal places. Between 1.13 and 1.14 numpy changed the default, so the comparisons change.

            Show
            tjenness Tim Jenness added a comment - After some discussion on Slack, Michael Wood-Vasey pointed out that the problem is that the demo text files are written using default stringification, rather than constraining the formatting to a specific number of decimal places. Between 1.13 and 1.14 numpy changed the default, so the comparisons change.
            Hide
            krughoff Simon Krughoff added a comment -

            This is taken care of in DM-14806. See PR for solution.

            Show
            krughoff Simon Krughoff added a comment - This is taken care of in DM-14806 . See PR for solution.
            Hide
            krughoff Simon Krughoff added a comment -

            Turns out that DM-14806 grew enough that it couldn't be merged immediately. In order to unblock this I cherry picked the relevant commits over.

            Show
            krughoff Simon Krughoff added a comment - Turns out that DM-14806 grew enough that it couldn't be merged immediately. In order to unblock this I cherry picked the relevant commits over.
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me.

            Show
            tjenness Tim Jenness added a comment - Looks good to me.

              People

              • Assignee:
                krughoff Simon Krughoff
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Tim Jenness
                Watchers:
                Brian Van Klaveren, Chris Walter, Gabriele Comoretto, John Swinbank, Joshua Hoblitt, Russell Owen, Simon Krughoff, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel