Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15046

When comparing angles in MatchPessimisticB, make sure all vectors are plane projected

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None

      Description

      This was discussed in DMTN-031.

        Attachments

          Issue Links

            Activity

            Hide
            cmorrison Chris Morrison added a comment -

            This ticket is mostly straight forward as it says in the description. However, there are a few changes to method call signatures in this ticket. One thing to double check is that the doc strings are changed appropriately for the changes in call signature.

            Show
            cmorrison Chris Morrison added a comment - This ticket is mostly straight forward as it says in the description. However, there are a few changes to method call signatures in this ticket. One thing to double check is that the doc strings are changed appropriately for the changes in call signature.
            Hide
            swinbank John Swinbank added a comment -

            Since Dan Taranu is away, I took a look through Chris's responses to the review comments and I think they're fine so I'm going to suggest we shouldn't hold this open until Dan gets back. Dan, if there's anything here you remain unhappy with, give us a ping when you get back and we'll open a new ticket to fix it.

            Show
            swinbank John Swinbank added a comment - Since Dan Taranu is away, I took a look through Chris's responses to the review comments and I think they're fine so I'm going to suggest we shouldn't hold this open until Dan gets back. Dan, if there's anything here you remain unhappy with, give us a ping when you get back and we'll open a new ticket to fix it.
            Hide
            dtaranu Dan Taranu added a comment -

            I'm fine with the changes.

            Show
            dtaranu Dan Taranu added a comment - I'm fine with the changes.
            Show
            cmorrison Chris Morrison added a comment - Successful Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28219/

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Dan Taranu
                Watchers:
                Chris Morrison, Dan Taranu, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel