Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15090

Stop using file in Python code

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      AP F18-1
    • Team:
      Alert Production

      Description

      We are still using the old `file` class in some Python code, even though it is not available in Python 3. It should be replaced with `open`.

      Also, pep8 catches this so I suggest making the packages pep8 compliant, enabling automatic checking and removing python 2 support (all of which should be trivial).

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Risk Score 0
          rowen Russell Owen made changes -
          Assignee Russell Owen [ rowen ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Please have a look. I did not work on doc string or comment length (except in a few cases where it was trivial, in passing).

          Once this is merged one of us make travis checking required for merging to master for both packages.

          Show
          rowen Russell Owen added a comment - Please have a look. I did not work on doc string or comment length (except in a few cases where it was trivial, in passing). Once this is merged one of us make travis checking required for merging to master for both packages.
          rowen Russell Owen made changes -
          Reviewers Tim Jenness [ tjenness ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          rowen Russell Owen made changes -
          Epic Link DM-14447 [ 80385 ]
          rowen Russell Owen made changes -
          Sprint AP F18-1 [ 746 ]
          Story Points 0.5
          Team Alert Production [ 10300 ]
          Labels SciencePipelines
          rowen Russell Owen made changes -
          Description We are still using the old `file` class in some Python code, even though it is not available in Python 3. It should be replaced with `open`.

          Also, pep8 catches this so I suggest that the packages in question be made pep8 compliant and automatic checking enabled.           		We are still using the old `file` class in some Python code, even though it is not available in Python 3. It should be replaced with `open`.

          Also, pep8 catches this so I suggest making the packages pep8 compliant, enabling automatic checking and removing python 2 support (all of which should be trivial).
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Looks good. Thanks.

          Show
          tjenness Tim Jenness added a comment - Looks good. Thanks.
          tjenness Tim Jenness made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Thank you for the quick review. I made Travis a requirement for merging to master for both packages.

          Show
          rowen Russell Owen added a comment - - edited Thank you for the quick review. I made Travis a requirement for merging to master for both packages.
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tim Jenness
            Watchers:
            Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.