Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15090

Stop using file in Python code

    XMLWordPrintable

Details

    • 0.5
    • AP F18-1
    • Alert Production

    Description

      We are still using the old `file` class in some Python code, even though it is not available in Python 3. It should be replaced with `open`.

      Also, pep8 catches this so I suggest making the packages pep8 compliant, enabling automatic checking and removing python 2 support (all of which should be trivial).

      Attachments

        Activity

          rowen Russell Owen added a comment -

          Please have a look. I did not work on doc string or comment length (except in a few cases where it was trivial, in passing).

          Once this is merged one of us make travis checking required for merging to master for both packages.

          rowen Russell Owen added a comment - Please have a look. I did not work on doc string or comment length (except in a few cases where it was trivial, in passing). Once this is merged one of us make travis checking required for merging to master for both packages.
          tjenness Tim Jenness added a comment -

          Looks good. Thanks.

          tjenness Tim Jenness added a comment - Looks good. Thanks.
          rowen Russell Owen added a comment - - edited

          Thank you for the quick review. I made Travis a requirement for merging to master for both packages.

          rowen Russell Owen added a comment - - edited Thank you for the quick review. I made Travis a requirement for merging to master for both packages.

          People

            rowen Russell Owen
            rowen Russell Owen
            Tim Jenness
            Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.