Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15093

Disable y-band stray light correction after Jan 2018

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
    • Team:
      External

      Description

      Sogo Mineo (NAOJ) writes:

      the rotator LEDs have already been covered, and we have to uncomment this.

      It should be something like:

          if exposure.getDateObs() >= datetime.datetime(2018, 1, 1):
      		 
              return

      but exposure.getDateObs() has to be replaced with a correct expression.

      Koike-san found at least a field was affected by this bug around (ra, dec) = (157, 0).

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          price Paul Price created issue -
          price Paul Price made changes -
          Field Original Value New Value
          Risk Score 0
          Hide
          Permalink
          price Paul Price added a comment -

          Yusra AlSayyad, would you approve this simple change?

          price@pap-laptop:~/LSST/obs_subaru (tickets/DM-15093=) $ git sub-patch
          		 
          commit 248fab93c4b277f8942146a5b9500543c5f24e03 (HEAD -> tickets/DM-15093, origin/tickets/DM-15093)
          		 
          Author: Paul Price <price@astro.princeton.edu>
          		 
          Date:   Sat Jul 14 10:15:33 2018 -0400
          		 
           
          		 
              yStrayLight: disable correction after 2018-01-01
          		 
              
              The LEDs causing the stray light were covered up at this date, and we
          		 
              believe there is no remaining stray light.
          		 
           
          		 
          diff --git a/python/lsst/obs/subaru/strayLight/yStrayLight.py b/python/lsst/obs/subaru/strayLight/yStrayLight.py
          		 
          index 7f058c1..2822c5a 100644
          		 
          --- a/python/lsst/obs/subaru/strayLight/yStrayLight.py
          		 
          +++ b/python/lsst/obs/subaru/strayLight/yStrayLight.py
          		 
          @@ -19,6 +19,7 @@ from __future__ import absolute_import, division, print_function
          		 
           __all__ = ["StrayLightTask"]
          		 
           
           import os
          		 
          +import datetime
          		 
           
           import numpy
          		 
           from astropy.io import fits
          		 
          @@ -83,13 +84,10 @@ class StrayLightTask(Task):
          		 
                   if sensorRef.dataId["ccd"] in range(104, 112):
          		 
                       # No correction data: assume it's zero
          		 
                       return
          		 
          -
          		 
          -        # The LEDs that are causing the Y straylight have not been covered yet (on 2017-11-27),
          		 
          -        # but they will be covered in the near future.
          		 
          -        # Once the LEDs are covered, we will have to uncomment the following statement:
          		 
          -        #
          		 
          -        # if (ccdExposure is newer than a certain date):
          		 
          -        #     return
          		 
          +        if exposure.getInfo().getVisitInfo().getDate().toPython() >= datetime.datetime(2018, 1, 1):
          		 
          +            # LEDs causing the stray light have been covered up.
          		 
          +            # We believe there is no remaining stray light.
          		 
          +            return
          		 
           
                   header = sensorRef.get('raw_md')
          		 
                   if self.config.doRotatorAngleCorrection:

          Show
          price Paul Price added a comment - Yusra AlSayyad , would you approve this simple change? price@pap-laptop:~/LSST/obs_subaru (tickets/DM-15093=) $ git sub-patch commit 248fab93c4b277f8942146a5b9500543c5f24e03 (HEAD -> tickets/DM-15093, origin/tickets/DM-15093) Author: Paul Price <price@astro.princeton.edu> Date: Sat Jul 14 10:15:33 2018 -0400   yStrayLight: disable correction after 2018-01-01 The LEDs causing the stray light were covered up at this date, and we believe there is no remaining stray light.   diff --git a/python/lsst/obs/subaru/strayLight/yStrayLight.py b/python/lsst/obs/subaru/strayLight/yStrayLight.py index 7f058c1..2822c5a 100644 --- a/python/lsst/obs/subaru/strayLight/yStrayLight.py +++ b/python/lsst/obs/subaru/strayLight/yStrayLight.py @@ -19,6 +19,7 @@ from __future__ import absolute_import, division, print_function __all__ = ["StrayLightTask"] import os +import datetime import numpy from astropy.io import fits @@ -83,13 +84,10 @@ class StrayLightTask(Task): if sensorRef.dataId["ccd"] in range(104, 112): # No correction data: assume it's zero return - - # The LEDs that are causing the Y straylight have not been covered yet (on 2017-11-27), - # but they will be covered in the near future. - # Once the LEDs are covered, we will have to uncomment the following statement: - # - # if (ccdExposure is newer than a certain date): - # return + if exposure.getInfo().getVisitInfo().getDate().toPython() >= datetime.datetime(2018, 1, 1): + # LEDs causing the stray light have been covered up. + # We believe there is no remaining stray light. + return header = sensorRef.get('raw_md') if self.config.doRotatorAngleCorrection:
          price Paul Price made changes -
          Reviewers Yusra AlSayyad [ yusra ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          OK to merge

          Show
          yusra Yusra AlSayyad added a comment - OK to merge
          yusra Yusra AlSayyad made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          price Paul Price added a comment -

          Thanks Yusra.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Yusra. Merged to master.
          price Paul Price made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Yusra AlSayyad
            Watchers:
            Paul Price, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.