Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15098

Add Registry.getRegion(DataId)

    Details

      Description

      Add Registry.getRegion(DataId) -> sphgeom.Region that returns the intersection of all regions associated with the DataUnit in the DataId.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            Initial version implemented. Also needed a reverse-lookup (DataUnitRegistry.getByLinkName) from link-column-name to DataUnit instance (that now also knows if a region is associated with it).
            Still needs cleanup and checks for corner cases in the lookup, but should unblock Nate Lust.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited Initial version implemented. Also needed a reverse-lookup ( DataUnitRegistry.getByLinkName ) from link-column-name to DataUnit instance (that now also knows if a region is associated with it). Still needs cleanup and checks for corner cases in the lookup, but should unblock Nate Lust .
            Hide
            salnikov Andy Salnikov added a comment -

            Pim Schellart [X], I am messing with DataUnits and regionColumn too in my DM-15049 ticket. I think there should not be a conflict (I have added DataUnit.regionColumn() method too) but could you also check my my commit is not doing something that may break yours: https://github.com/lsst/daf_butler/compare/tickets/DM-15049

            Show
            salnikov Andy Salnikov added a comment - Pim Schellart [X] , I am messing with DataUnits and regionColumn too in my DM-15049 ticket. I think there should not be a conflict (I have added DataUnit.regionColumn() method too) but could you also check my my commit is not doing something that may break yours: https://github.com/lsst/daf_butler/compare/tickets/DM-15049
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Note that this does not (currently) return the intersection. Multiple spatial DataUnits associated with the same DataId are not (yet) implemented due to missing support for sphgeom::ConvexPolygon::intersection.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Note that this does not (currently) return the intersection. Multiple spatial DataUnits associated with the same DataId are not (yet) implemented due to missing support for sphgeom::ConvexPolygon::intersection .
            Hide
            tjenness Tim Jenness added a comment -

            Minor comments regarding docstring and test coverage but otherwise looks ok.

            Show
            tjenness Tim Jenness added a comment - Minor comments regarding docstring and test coverage but otherwise looks ok.
            Hide
            tjenness Tim Jenness added a comment - - edited

            Is there a ticket for fixing sphgeom that you can link here? And in fact is there a new ticket for extending region support in butler once sphgeom is fixed?

            Show
            tjenness Tim Jenness added a comment - - edited Is there a ticket for fixing sphgeom that you can link here? And in fact is there a new ticket for extending region support in butler once sphgeom is fixed?
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Found some major corner cases that required completely reworking the design since the last review. So putting back in review.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Found some major corner cases that required completely reworking the design since the last review. So putting back in review.

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                Nate Lust
                Watchers:
                Andy Salnikov, Jim Bosch, Nate Lust, Pim Schellart [X] (Inactive), Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel