Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15104

Move SourceDeblendTask out of MeasureCoaddSources

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      DRP F18-2, DRP F18-3
    • Team:
      Data Release Production

      Description

      Currently the deblender is run as part of the MeasureCoaddSources task. In order to make it easier to swap out the current and future deblenders , SourceDeblendTask should be pulled out and placed in a new DeblendCoaddSourcesTask, along with an option to run MultibandDeblendTask instead. The current version of SCARLET also needs to be added to the stack as a 3rd party package.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8621 Reorganize deblender tasks

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15108 Create a tutorial for the deblending workshop

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15106 Update the deblender to use multiband classes

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15246 Add scarlet as a 3rd party package to the stack

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-504 Add SCARLET as a 3rd party package to the stack

          • Implemented
          is parent task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15534 Undefined variable names in MultibandDriver

          • Done
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-15426 Update obs_subaru with the new multiband task structure

          • To Do

          Bug - A problem which impairs or prevents the functions of the product. DM-15415 weekly-release w.2018.32 failed

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-16169 Update pipelines.lsst.io getting started for deblendCoaddSources.py task

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Hi Nate,
            Would you mind reviewing this ticket by tomorrow? pipe_tasks is the only package with substantial changes, the others are just updated to use the new task structure.

            Thanks,
            -Fred

            Show
            fred3m Fred Moolekamp added a comment - Hi Nate, Would you mind reviewing this ticket by tomorrow? pipe_tasks is the only package with substantial changes, the others are just updated to use the new task structure. Thanks, -Fred
            Hide
            Permalink
            nlust Nate Lust added a comment -

            I think I covered everything. Most changes/questions are in pipe_tasks, with the rest looking either strait forward, or discussed in person, as the bandwidth was higher than github comments.

            Please Please Please run tests (actual processing and jenkins) a few times before merging (don't forget to take out the catalog slice after) before merging. There have many breakages lately, and a lot of churn, so just do your due diligence.

            Show
            nlust Nate Lust added a comment - I think I covered everything. Most changes/questions are in pipe_tasks, with the rest looking either strait forward, or discussed in person, as the bandwidth was higher than github comments. Please Please Please run tests (actual processing and jenkins) a few times before merging (don't forget to take out the catalog slice after) before merging. There have many breakages lately, and a lot of churn, so just do your due diligence.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Thanks for the very quick review Nate Lust! I ran on Jenkins pre-review (https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28369/pipeline) and have started a new Jenkins build that I will wait to complete before merging. If Paul Price, Yusra AlSayyad, Jim Bosch, Tim Jenness or anyone else knows of any modules not executed in lsst_distrib or the demo that called MeasureMergedCoaddSourcesTask directly (as opposed to calling through MultibandDriver please let me know so that I can make sure it works with the new task structure.

            Show
            fred3m Fred Moolekamp added a comment - Thanks for the very quick review Nate Lust ! I ran on Jenkins pre-review ( https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28369/pipeline ) and have started a new Jenkins build that I will wait to complete before merging. If Paul Price , Yusra AlSayyad , Jim Bosch , Tim Jenness or anyone else knows of any modules not executed in lsst_distrib or the demo that called MeasureMergedCoaddSourcesTask directly (as opposed to calling through MultibandDriver please let me know so that I can make sure it works with the new task structure.
            Hide
            Permalink
            price Paul Price added a comment -

            If it works with ci_hsc, I'm happy.

            Show
            price Paul Price added a comment - If it works with ci_hsc, I'm happy.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Merged branches.

            Show
            fred3m Fred Moolekamp added a comment - Merged branches.

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Nate Lust
              Watchers:
              Fred Moolekamp, Nate Lust, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.