Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15126

Make meas_* compatible with pybind11 2.2 (as well as 2.1)

    XMLWordPrintable

    Details

    • Story Points:
      0.25
    • Epic Link:
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      The only problem in meas_base was "fail" was being wrapped on the wrong class (pybind11 2.2 is picker about this). I originally thought the problem was bigger and ended up making minor changing two other meas_ packages, but I was wrong and will drop those changes.

      I also took the opportunity to modernize the use of anonymous namespaces and run clang-format on the wrappers.

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-14828 Upgrade pybind11 to 2.2.3

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good now.

            Show
            krzys Krzysztof Findeisen added a comment - Looks good now.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you for the very helpful review. You made the resulting code a lot better.

            I ended up merging all three branches after making two of them basically trivial (hide .coverage in one and run clang-format on the pybind11 wrapper in the other). I figured it would not hurt.

            Show
            rowen Russell Owen added a comment - Thank you for the very helpful review. You made the resulting code a lot better. I ended up merging all three branches after making two of them basically trivial (hide .coverage in one and run clang-format on the pybind11 wrapper in the other). I figured it would not hurt.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, Krzysztof Findeisen, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.