Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15127

validateDrp.py doesn't like the NB0921 filter

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: validate_drp
    • Labels:
      None
    • Team:
      SQuaRE

      Description

      Using w_2018_28 and running validateDrp.py on a filter=NB0921 json file generated by matchedVisitMetrics.py gives the following error

      Traceback (most recent call last):
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/validate_drp/16.0-4-g0b0e9de+6/bin/validateDrp.py", line 109, in <module>
      		 
          validate.run(args.repo, **kwargs)
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/validate_drp/16.0-4-g0b0e9de+6/python/lsst/validate/drp/validate.py", line 157, in run
      		 
          print_metrics(job)
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/validate_drp/16.0-4-g0b0e9de+6/python/lsst/validate/drp/validate.py", line 482, in print_metrics
      		 
          metric = job.metrics[metric_set[0]] # Pick the first one for the description
      		 
        File "/software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/verify/16.0+1/python/lsst/verify/metricset.py", line 207, in __getitem__
      		 
          return self._metrics[key]
      		 
      KeyError: Name('release', 'PF1')

      To reproduce, try 

      validateDrp.py /datasets/hsc/repo/rerun/RC/w_2018_28/DM-14988/validateDrp/matchedVisitMetrics/9813/NB0921/matchedVisit_NB0921.json --noplot

      or a newer biweekly equivalent.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15119 Run pipe_analysis and validate_drp with w_2018_28 HSC RC2 outputs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34571 Make faro not run on narrow bands

          • To Do
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            validate_drp is deprecated so this ticket is no longer valid as-is. Keith Bechtol is this at all relevant for faro?

            Show
            tjenness Tim Jenness added a comment - validate_drp is deprecated so this ticket is no longer valid as-is. Keith Bechtol is this at all relevant for faro?
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            At the DRP metrics meeting a month ago Jeffrey Carlin got an action to "Make faro not attempt running on narrow-bands." to https://confluence.lsstcorp.org/display/DM/DRP+Metrics+Monitoring+2022-02-28

            I can't find a ticket for that, so maybe we can repurpose this ticket. 

            Show
            yusra Yusra AlSayyad added a comment - At the DRP metrics meeting a month ago Jeffrey Carlin  got an action to "Make faro not attempt running on narrow-bands." to https://confluence.lsstcorp.org/display/DM/DRP+Metrics+Monitoring+2022-02-28 I can't find a ticket for that, so maybe we can repurpose this ticket. 
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Also, Jim Bosch suggested that there was a way for faro task to, at QG generation time, throw away any quanta for narrow bands. 

            Show
            yusra Yusra AlSayyad added a comment - Also, Jim Bosch suggested that there was a way for faro task to, at QG generation time, throw away any quanta for narrow bands. 
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks. I'm more than happy for the component to be changed to faro and the description tweaked.

            Show
            tjenness Tim Jenness added a comment - Thanks. I'm more than happy for the component to be changed to faro and the description tweaked.
            Hide
            Permalink
            lguy Leanne Guy added a comment -

            faro does not use validateDrp.py so I think I'd rather close this ticket and make a new ticket for faro

            Show
            lguy Leanne Guy added a comment - faro does not use validateDrp.py so I think I'd rather close this ticket and make a new ticket for faro
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Please link the new ticket to this one when you make the new ticket (and then mark this one INVALID).

            Show
            tjenness Tim Jenness added a comment - Please link the new ticket to this one when you make the new ticket (and then mark this one INVALID).

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Leanne Guy, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.