Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15132

Fix errors in jointcal pybind11 wrappers

    XMLWordPrintable

    Details

    • Story Points:
      0.25
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      jointcal wraps a few methods on the wrong class (exposed by pybind11 2.2)

      Also pybind11 2.2 does not allow one to specify both std::shared_ptr<Foo> and std::unique_ptr<Foo> as template parameters for py::class_ and this was being done for Gtransfo; fortunately none of the methods that use unique pointers was wrapped so I didn't have to add any workarounds.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Looks good. Maybe some day the wrappers can be reworked to make future copy-and-paste errors less likely...

            Show
            krzys Krzysztof Findeisen added a comment - Looks good. Maybe some day the wrappers can be reworked to make future copy-and-paste errors less likely...

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, John Parejko, Krzysztof Findeisen, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.