Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15171

Silence warnings about aperture correction of undeblended convolved measurements

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      External

      Description

      Hsin-Fang Chiang writes:

      With w_2018_28 in forcedPhotCoadd, I got many WARNs like this:

      multiBandDriver.forcedPhotCoadd.applyApCorr: Cannot aperture correct undeblended_ext_convolved_ConvolvedFlux_1_6_0 because could not find undeblended_ext_convolved_ConvolvedFlux_1_6_0_flux or undeblended_ext_convolved_ConvolvedFlux_1_6_0_fluxSigma in apCorrMap
      

      These did not appear back in w_2018_26.

      This is from DM-15045.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Hsin-Fang Chiang, would you please review this small change?

            price@pap-laptop:~/LSST/obs_subaru (tickets/DM-15171=) $ git sub-patch
            commit b7bf971f365d1a3ace25c29fd1387527d25d961a (HEAD -> tickets/DM-15171, origin/tickets/DM-15171)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Jul 19 16:21:54 2018 -0400
             
                config: disable apCorr registration of undeblended convolved measurement
                
                This suppresses warnings of the type:
                
                    Cannot aperture correct undeblended_ext_convolved_ConvolvedFlux_1_6_0 because could not find undeblended_ext_convolved_ConvolvedFlux_1_6_0_flux or undeblended_ext_convolved_ConvolvedFlux_1_6_0_fluxSigma in apCorrMap
                
                Because the columns used by the convolved measurement are created at
                plugin instantiation (because the names are defined by the config),
                registration for the aperture correction is done at plugin instantiation
                time too. But we don't want them registered for the undeblended
                measurement because we'll get the aperture correction from the deblended
                proxy.
             
            diff --git a/config/forcedPhotCoadd.py b/config/forcedPhotCoadd.py
            index 91b2c0d7..e21793a4 100644
            --- a/config/forcedPhotCoadd.py
            +++ b/config/forcedPhotCoadd.py
            @@ -42,3 +42,5 @@ doUndeblended(config, "ext_photometryKron_KronFlux")
             doUndeblended(config, "base_CircularApertureFlux", [])  # No aperture correction for circular apertures
             doUndeblended(config, "ext_convolved_ConvolvedFlux",
                           config.measurement.plugins["ext_convolved_ConvolvedFlux"].getAllResultNames())
            +# Disable registration for apCorr of undeblended measurement; apCorr will be done through the deblended proxy
            +config.measurement.undeblended["ext_convolved_ConvolvedFlux"].registerForApCorr = False
            

            Show
            price Paul Price added a comment - Hsin-Fang Chiang , would you please review this small change? price@pap-laptop:~/LSST/obs_subaru (tickets/DM-15171=) $ git sub-patch commit b7bf971f365d1a3ace25c29fd1387527d25d961a (HEAD -> tickets/DM-15171, origin/tickets/DM-15171) Author: Paul Price <price@astro.princeton.edu> Date: Thu Jul 19 16:21:54 2018 -0400   config: disable apCorr registration of undeblended convolved measurement This suppresses warnings of the type: Cannot aperture correct undeblended_ext_convolved_ConvolvedFlux_1_6_0 because could not find undeblended_ext_convolved_ConvolvedFlux_1_6_0_flux or undeblended_ext_convolved_ConvolvedFlux_1_6_0_fluxSigma in apCorrMap Because the columns used by the convolved measurement are created at plugin instantiation (because the names are defined by the config), registration for the aperture correction is done at plugin instantiation time too. But we don't want them registered for the undeblended measurement because we'll get the aperture correction from the deblended proxy.   diff --git a/config/forcedPhotCoadd.py b/config/forcedPhotCoadd.py index 91b2c0d7..e21793a4 100644 --- a/config/forcedPhotCoadd.py +++ b/config/forcedPhotCoadd.py @@ -42,3 +42,5 @@ doUndeblended(config, "ext_photometryKron_KronFlux") doUndeblended(config, "base_CircularApertureFlux", []) # No aperture correction for circular apertures doUndeblended(config, "ext_convolved_ConvolvedFlux", config.measurement.plugins["ext_convolved_ConvolvedFlux"].getAllResultNames()) +# Disable registration for apCorr of undeblended measurement; apCorr will be done through the deblended proxy +config.measurement.undeblended["ext_convolved_ConvolvedFlux"].registerForApCorr = False
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            The change looks good to me

            Show
            hchiang2 Hsin-Fang Chiang added a comment - The change looks good to me
            Hide
            price Paul Price added a comment -

            Jenkins is green.

            Show
            price Paul Price added a comment - Jenkins is green.
            Hide
            price Paul Price added a comment -

            Verified that this works:

            pprice@lsst-dev01:/scratch/pprice/dm-15171/obs_subaru[tickets/DM-15171] $ forcedPhotCoadd.py /datasets/hsc/repo --rerun RC/w_2018_28/DM-14988:private/price/dm-15171 --calib /datasets/hsc/calib/20180117 --id tract=9813 patch=5,5 filter=HSC-R
            [...]
            root INFO: Loading config overrride file '/scratch/pprice/dm-15171/obs_subaru/config/forcedPhotCoadd.py'
            CameraMapper INFO: Loading exposure registry from /datasets/hsc/repo/registry.sqlite3
            CameraMapper INFO: Loading calib registry from /datasets/hsc/repo/CALIB/calibRegistry.sqlite3
            CameraMapper INFO: Loading calib registry from /datasets/hsc/repo/CALIB/calibRegistry.sqlite3
            CameraMapper INFO: Loading calib registry from /datasets/hsc/calib/20180117/calibRegistry.sqlite3
            root INFO: Running: /software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/meas_base/16.0-8-g2ce35ff/bin/forcedPhotCoadd.py /datasets/hsc/repo --rerun RC/w_2018_28/DM-14988:private/price/dm-15171 --calib /datasets/hsc/calib/20180117 --id tract=9813 patch=5,5 filter=HSC-R
            forcedPhotCoadd.references INFO: Getting references in {'tract': 9813, 'patch': '5,5'}
            forcedPhotCoadd INFO: Performing forced measurement on DataId(initialdata={'tract': 9813, 'patch': '5,5', 'filter': 'HSC-R'}, tag=set())
            forcedPhotCoadd INFO: Loading deblended footprints for sources from meas, DataId(initialdata={'tract': 9813, 'patch': '5,5', 'filter': 'HSC-R'}, tag=set())
            forcedPhotCoadd.measurement INFO: Performing forced measurement on 30485 sources
            forcedPhotCoadd.applyApCorr INFO: Applying aperture corrections to 39 flux fields
            

            Show
            price Paul Price added a comment - Verified that this works: pprice@lsst-dev01:/scratch/pprice/dm-15171/obs_subaru[tickets/DM-15171] $ forcedPhotCoadd.py /datasets/hsc/repo --rerun RC/w_2018_28/DM-14988:private/price/dm-15171 --calib /datasets/hsc/calib/20180117 --id tract=9813 patch=5,5 filter=HSC-R [...] root INFO: Loading config overrride file '/scratch/pprice/dm-15171/obs_subaru/config/forcedPhotCoadd.py' CameraMapper INFO: Loading exposure registry from /datasets/hsc/repo/registry.sqlite3 CameraMapper INFO: Loading calib registry from /datasets/hsc/repo/CALIB/calibRegistry.sqlite3 CameraMapper INFO: Loading calib registry from /datasets/hsc/repo/CALIB/calibRegistry.sqlite3 CameraMapper INFO: Loading calib registry from /datasets/hsc/calib/20180117/calibRegistry.sqlite3 root INFO: Running: /software/lsstsw/stack3_20171023/stack/miniconda3-4.3.21-10a4fa6/Linux64/meas_base/16.0-8-g2ce35ff/bin/forcedPhotCoadd.py /datasets/hsc/repo --rerun RC/w_2018_28/DM-14988:private/price/dm-15171 --calib /datasets/hsc/calib/20180117 --id tract=9813 patch=5,5 filter=HSC-R forcedPhotCoadd.references INFO: Getting references in {'tract': 9813, 'patch': '5,5'} forcedPhotCoadd INFO: Performing forced measurement on DataId(initialdata={'tract': 9813, 'patch': '5,5', 'filter': 'HSC-R'}, tag=set()) forcedPhotCoadd INFO: Loading deblended footprints for sources from meas, DataId(initialdata={'tract': 9813, 'patch': '5,5', 'filter': 'HSC-R'}, tag=set()) forcedPhotCoadd.measurement INFO: Performing forced measurement on 30485 sources forcedPhotCoadd.applyApCorr INFO: Applying aperture corrections to 39 flux fields
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Hsin-Fang Chiang
                Watchers:
                Hsin-Fang Chiang, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel