Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15182

Add facility to change matplotlib colormap

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: display_matplotlib
    • Labels:
      None

      Description

      On https://github.com/lsst/display_matplotlib/issues/1, the request is:

      Would it be possible to give the user control over the colormap used to display images? I see that this is currently set to cmap=pyplot.cm.gray.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15218 Add API to afwDisplay.Display to select the colour map

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Alex Drlica-Wagner provided a suggested fix. PR is now here:

            https://github.com/lsst/display_matplotlib/pull/8

            Robert Lupton, could you review please?

            Show
            swinbank John Swinbank added a comment - Alex Drlica-Wagner provided a suggested fix. PR is now here: https://github.com/lsst/display_matplotlib/pull/8 Robert Lupton, could you review please?
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            I don't think I want to pass a pyplot.cm.XXX object to setImageColormap; so display.setImageColormap("gray").  If you agree (or can't convince me to the contrary) I'll make that change.  It would be nice to come up with a subset of commonly supported names;  at the very least "gray"

            Show
            rhl Robert Lupton added a comment - I don't think I want to pass a pyplot.cm.XXX object to setImageColormap ; so display.setImageColormap("gray") .  If you agree (or can't convince me to the contrary) I'll make that change.  It would be nice to come up with a subset of commonly supported names;  at the very least "gray"
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Merged to master.  Tests pass

             

            Show
            rhl Robert Lupton added a comment - Merged to master.  Tests pass  
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Robert Lupton — this doesn't actually seem to be on master at https://github.com/lsst/display_matplotlib.

            Show
            swinbank John Swinbank added a comment - Robert Lupton — this doesn't actually seem to be on master at https://github.com/lsst/display_matplotlib .
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Maybe a git push will help (sorry, I ran scons one last time instead)

             

            Show
            rhl Robert Lupton added a comment - Maybe a git push will help (sorry, I ran scons one last time instead)  

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Robert Lupton
              Watchers:
              John Swinbank, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.